Bugs in book

[jeertmans]

Here is a short list of bugs / improvements for the book

• https://logos.maciej.codes/attributes/logos.html is missing documentation about subpatterns;
• broken link to regex in https://logos.maciej.codes/attributes/logos.html; (see 0f361d6)
• outdated version of regex-syntax crate in https://logos.maciej.codes/common-regex.html.

Please feel free to open a PR if you want to fix those issues!

[fmorroni]

Hi I'd like to handle these improvements to the documentation. I can add the section regarding subpatterns, and I'd also like to add a section for contexts/morphing which I don't think is mentioned at all in the book.

broken link to regex in https://logos.maciej.codes/attributes/logos.html;

I think this has already been fixed, at the very leas the link isn't broken, do you think it should point somewhere else?

This should also be fixed in the docs.

[fmorroni]

Also, regarding the debugging section, I think it should be mentioned how the initial state is chosen from the generated DFA.
In the given example, when explaining how to match the "fast" token, it's mentioned that the search begins by looking at state 9, but we could just as well have started from state 4 which wouldn't have matched with the proper token.
From my testing I believe the initial state is always the one with the largest value (9 in this case), but I'm not sure if this is really the case or just a coincidence.

[jeertmans]

Hi @fmorroni, I'd be more than happy to accept any PR that improves the docs :-)

broken link to regex in https://logos.maciej.codes/attributes/logos.html;

I think this has already been fixed, at the very leas the link isn't broken, do you think it should point somewhere else?

Indeed, this was fixed in 0f361d6.

Also, regarding the debugging section, I think it should be mentioned how the initial state is chosen from the generated DFA.

Yes! The debugging section is still incomplete, and any addition to it is very welcome!

About the initial state theory, this makes sense, but I didn't proof-check this (I didn't write this part of the code), so it might be safe to verify this by checking relevant source code.

Feel free to create a first PR, and we will see if anything needs to be changed / added.