Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DMG fails to build #580

Open
machawk1 opened this issue Oct 14, 2024 · 3 comments
Open

DMG fails to build #580

machawk1 opened this issue Oct 14, 2024 · 3 comments

Comments

@machawk1
Copy link
Owner

machawk1 commented Oct 14, 2024

As reported by Dhanashree, in building the DMG using the MAKEFILE:

biplist.InvalidPlistException: module 'plistlib' has no attribute 'Data'

It seems the `biplist` library is attempting to access an attribute `Data` in `plistlib`, which has been removed in Python 3.11. I believe this is causing the `InvalidPlistException` error, as `biplist` is trying to read a plist file but is not compatible with the new version of Python.

To address this issue, I am considering the following potential fixes:
1. Update biplist: I will check if there is an updated version of the biplist  library that resolves this compatibility issue with Python 3.11.
2. Modify the code to use plistlib directly: Since recent versions of  plistlib support both binary and XML plist files, I could replace `biplist` with `plistlib` in the affected part of the code.

I verified that the issue persists in Python 3.12.0, macOS 14.6.1, Apple M1, current main branch HEAD 041be9b.

@dhanashreedeshmukh
Copy link

The plistlib.Data compatibility issue with Python 3.11 has been resolved! I replaced plistlib.Data with bytes in biplist, and it now works smoothly.

@machawk1
Copy link
Owner Author

machawk1 commented Nov 4, 2024

@dhanashreedeshmukh Can you submit a PR to this repo with this fix in place? I can then merge it in and we can close this issue. Thanks!

@dhanashreedeshmukh
Copy link

dhanashreedeshmukh commented Nov 4, 2024 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants