Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not all default meta is handled on import #190

Open
mAAdhaTTah opened this issue Dec 18, 2017 · 6 comments · May be fixed by #208
Open

Not all default meta is handled on import #190

mAAdhaTTah opened this issue Dec 18, 2017 · 6 comments · May be fixed by #208

Comments

@mAAdhaTTah
Copy link
Owner

Source: https://wordpress.org/support/topic/empty-excerpt-after-import/

Related code: https://github.com/mAAdhaTTah/wordpress-github-sync/blob/master/lib/import.php#L164-L207

Not all meta is handled by this step.

@mAAdhaTTah mAAdhaTTah added the bug label Dec 18, 2017
@stebrech
Copy link

Have anyone could look into this bug already?

@mAAdhaTTah
Copy link
Owner Author

Not yet, and I haven't been working on this plugin as much, as I've been focused on getting wp-gistpen out the door.

@palmiak palmiak linked a pull request Oct 8, 2019 that will close this issue
@statnmap
Copy link

statnmap commented May 15, 2020

Do the additions made by @litefeel in https://github.com/litefeel/wp-github-sync-meta would be included in your plugin directly if you fill this issue ?
Sorry, I cannot really help in development, but I am using your plugin and try to find out if I can continue to use it considering you still do not have help to maintain it.

@mAAdhaTTah
Copy link
Owner Author

@statnmap I'm open to adding those things, yeah. I pinged him previously to see if he wanted to combine efforts here but I haven't heard from him.

FWIW, I have this plugin installed on my site and continue to use it without issue, so it should still work, even if I'm not actively maintaining it.

@statnmap
Copy link

Thanks. It also work on my website. My concern is more a security issue. I wouldn't like having an open gate.

@mAAdhaTTah
Copy link
Owner Author

@statnmap I actually misread the link and thought you were pointing here: https://github.com/litefeel/writing-on-github

Regardless, that plugin seems mostly fine, although I think the inclusion of this filter is very odd and doesn't really belong in the plugin. But you could easily copy that plugin code into your own site and do with it what you want.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants