Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PE: TLS parser generics and bitness-related rework #433

Open
Tracked by #434
kkent030315 opened this issue Nov 3, 2024 · 0 comments
Open
Tracked by #434

PE: TLS parser generics and bitness-related rework #433

kkent030315 opened this issue Nov 3, 2024 · 0 comments

Comments

@kkent030315
Copy link
Contributor

Reference: #425 (comment)

TL;DR:

  • Deprecate TlsData::parse, TlsData::parse_with_opts that uses unintuitive generics.
    • Instead, we should ideally have is_64.
  • Make independent ImageTlsDirectory(64) and ImageTlsDirectory32, and impl <From<ImageTlsDirectory32>> for ImageTlsDirectory(64) to merge.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@kkent030315