-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cmip26.py
script name is mistaken (CM2.6, not CMIP)
#87
Comments
Thanks @jbusecke . I'm 99% sure you're correct, I've been stating that the data we train on is from CM2.6. Not sure where The data step refactor should fix this. In the meantime, @arthurBarthe would you have any clarifications? |
That is correct, the name cmip26 comes from some initial confusion of mine which I never corrected. Maybe cm26_data_step.py? |
Will discuss in next dev meeting tomorrow. |
Will be closed by #85 . |
#85 is merged but we still need to do this (see e.g., https://github.com/m2lines/gz21_ocean_momentum/blob/main/src/gz21_ocean_momentum/cmip26.py). |
handled in #97 |
cmip26.py
script name is mistaken (CM2.6, not CMIP)
Quick very minor nitpick comment. The cmip26.py naming seems confusing to me. As I understand (and please correct me if I am wrong) the data used here is the CM2.6 GFDL simulation which is, despite the very similar name, not related to the Coupled Model Intercomparison Project (CMIP). Since CMIP is a very recognizable name in the climate community I would suggest to rename this module to avoid confusion.
The text was updated successfully, but these errors were encountered: