Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmip26.py script name is mistaken (CM2.6, not CMIP) #87

Closed
jbusecke opened this issue Aug 23, 2023 · 6 comments · Fixed by #97
Closed

cmip26.py script name is mistaken (CM2.6, not CMIP) #87

jbusecke opened this issue Aug 23, 2023 · 6 comments · Fixed by #97

Comments

@jbusecke
Copy link

Quick very minor nitpick comment. The cmip26.py naming seems confusing to me. As I understand (and please correct me if I am wrong) the data used here is the CM2.6 GFDL simulation which is, despite the very similar name, not related to the Coupled Model Intercomparison Project (CMIP). Since CMIP is a very recognizable name in the climate community I would suggest to rename this module to avoid confusion.

@raehik
Copy link
Contributor

raehik commented Aug 24, 2023

Thanks @jbusecke . I'm 99% sure you're correct, I've been stating that the data we train on is from CM2.6. Not sure where cmip26 came from, or if cmip comes up much else in the project (I don't believe so).

The data step refactor should fix this. In the meantime, @arthurBarthe would you have any clarifications?

@arthurBarthe
Copy link
Collaborator

That is correct, the name cmip26 comes from some initial confusion of mine which I never corrected. Maybe cm26_data_step.py?

@raehik
Copy link
Contributor

raehik commented Sep 12, 2023

Will discuss in next dev meeting tomorrow.

@raehik
Copy link
Contributor

raehik commented Sep 14, 2023

Will be closed by #85 .

@dorchard
Copy link
Collaborator

#85 is merged but we still need to do this (see e.g., https://github.com/m2lines/gz21_ocean_momentum/blob/main/src/gz21_ocean_momentum/cmip26.py).

@raehik raehik added this to the 2023-10 wrap-up milestone Oct 26, 2023
@raehik
Copy link
Contributor

raehik commented Oct 26, 2023

handled in #97

@raehik raehik changed the title cmip2.6 name could confuse people cmip26.py script name is mistaken (CM2.6, not CMIP) Dec 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants