Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Catch subdomain configuration errors between training data generation and model training #77

Open
raehik opened this issue Aug 14, 2023 · 1 comment
Labels
enhancement New feature or request post-iccs-2023 Issues created during the ICCS 2023 project, but not completed.

Comments

@raehik
Copy link
Contributor

raehik commented Aug 14, 2023

The data processing step generates forcings from the CM2.6 dataset for the given spatial domain and time resolution. The training step then works on subdomains of this forcing dataset. These subdomains are configured in the training_subdomains.yaml file (or as of #97 , an arbitrary YAML file with similar syntax). xarray doesn't care if a subdomain isn't fully located in the given forcing domain, it simply continues with as much overlap as present. If this overlap is too small, we may get a runtime error stating that the input size is too small for the neural net kernel (5x5). See #42 , #75 .

Going backwards from that error message to the reason is not obvious. We should catch this sort of misconfiguration and warn the user if they might see such an issue. A couple of options:

  • Assert that all subdomains are fully contained in the forcing data domain. If not, warn about possible misconfiguration.
  • Assert that subdomain size is appropriate for kernel size. Pytorch does this somewhat for us, but doesn't/can't provide much detail. We'd need to fiddle a bit with the Pytorch model for this e.g. export X and Y kernel sizes -- or maybe it's possible to query a neural net's kernel size in Pytorch?
@raehik
Copy link
Contributor Author

raehik commented Sep 20, 2023

#85 includes some related code for validating bounding boxes, which I intend to use in the training step too (it'd help for some misconfigurations).

@raehik raehik changed the title Catch "training subdomain out of forcing data domain" configuration errors Catch subdomain configuration errors between training data generation and model training Dec 4, 2023
@raehik raehik added post-iccs-2023 Issues created during the ICCS 2023 project, but not completed. enhancement New feature or request labels Dec 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request post-iccs-2023 Issues created during the ICCS 2023 project, but not completed.
Projects
None yet
Development

No branches or pull requests

2 participants