Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature request]: Save room as template #60

Open
gbrian opened this issue Apr 12, 2022 · 2 comments
Open

[Feature request]: Save room as template #60

gbrian opened this issue Apr 12, 2022 · 2 comments
Labels
enhancement New feature or request

Comments

@gbrian
Copy link
Contributor

gbrian commented Apr 12, 2022

Hi,

On codx we want to create template room. So a user can "fork" existing room and work on his/her own copy.

Busiess case:

We have to create a coding test for new users. We create a room, we set all tools, firefox tabs and documentation needed. We save the room as "PythonTest-SQL-Test" for example. Then we share a link with the users https://codx.meetnav.com//clinic/PythonTest-SQL-Test so users will create a new room using that template.

Proposal

I'd like to have the option to save a room as template/image to create new rooms.

What about this changes:

  • Have a new set of API calls for template maintenance. CRUD operations for endpoint "/templates"
  • Add new setting to Create API call: templateId so you can build new room from an existing template

For templates we have different docker options like: commit, save, export... but looks like CHECKPOINT could be the best option.

https://stackoverflow.com/questions/45153855/is-there-a-way-to-hibernate-a-docker-container

@m1k1o m1k1o added the enhancement New feature or request label Apr 12, 2022
@gbrian
Copy link
Contributor Author

gbrian commented May 3, 2022

Hi,
Can we skip the "tag" section when validating the image name?
Like...

if in, _ := utils.ArrayIn(settings.NekoImages.split(":")[0], manager.config.NekoImages); !in {
	return "", fmt.Errorf("invalid neko image")
}

If want we can have a NEKO_ROOMS_NEKO_IMAGES_STRICT_TAGS=1 to allow this behavior or keep strict
So if I build different versions of same image "gbrian/neko:firefox-v2" they still valid.

@m1k1o
Copy link
Owner

m1k1o commented May 3, 2022

Or allow adding * in there? Meaning, you could allow m1k1o/neko:*, or m1k1o/*. If you would have own registry thenyour.registry.net/neko/*. Should be more flexible, because you can even put * and allow them all.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants