Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Automatically stop room when all admins leave #28

Closed
m1k1o opened this issue Nov 14, 2021 · 7 comments
Closed

[Feature] Automatically stop room when all admins leave #28

m1k1o opened this issue Nov 14, 2021 · 7 comments
Labels
enhancement New feature or request

Comments

@m1k1o
Copy link
Owner

m1k1o commented Nov 14, 2021

Should be toggle option. For better security.

@Hammyboo
Copy link

Hammyboo commented Jan 12, 2022

Should be either destroy or stop, the admin chooses between the two options what do you think? because with destroy it can save up ports.

but then if you add the destroy option it should have a counter, if admin leaves and didn't join back within a specific amount of hours the room will be deleted.

@m1k1o
Copy link
Owner Author

m1k1o commented Jan 12, 2022

That sounds as a good idea. Yes, exactly, there should be timeout how long a room can be active with no admin logged in and once it expires, that room would be garbage collected. Would be a nice feature for PR some day.

@Hammyboo
Copy link

yeah exactly

@Hammyboo
Copy link

Question tho, stopping the room stops it from taking any resources? because even when it is stopped the port is still staken, does it apply to the CPU and Ram usage?

@m1k1o
Copy link
Owner Author

m1k1o commented Jan 15, 2022

Yes, stopping the room stops it from taking any resources. Port allocation stays, because it is part of the initial configuration (when creating a room) and cannot be modified on start (those are docker limitations).

@Hammyboo
Copy link

Thank you for your answer <3

@m1k1o
Copy link
Owner Author

m1k1o commented Oct 5, 2023

Closed in favor of: #76

@m1k1o m1k1o closed this as completed Oct 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants