Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allowDismissByPanningPresentedView does not work with left/right panning #78

Open
phatmann opened this issue Apr 13, 2016 · 4 comments
Open

Comments

@phatmann
Copy link
Contributor

If my view slides in from the left and I have allowDismissByPanningPresentedView set to true, I would expect a pan gesture on the view to the left to dismiss the view. However, I can only pan the view up and down. Furthermore, when I pan up the view moves down and vice versa. The up/down pan gestures do not dismiss the view, but I would not expect them to do so.

@m1entus
Copy link
Owner

m1entus commented Apr 14, 2016

Feel free to make PR with functionality

@phatmann
Copy link
Contributor Author

I took a look at the relevant code but found it difficult to follow. Can you tell me the general intent of the pan gestures?

@m1entus
Copy link
Owner

m1entus commented Apr 19, 2016

By using pan gestures you can dismiss using some of edges of presented controller or by holding finger on presented view controller and slide it

@phatmann
Copy link
Contributor Author

Can you tell me exactly what those intended gestures are?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants