Skip to content

Commit

Permalink
Remove time filter for early-exit tests (#177)
Browse files Browse the repository at this point in the history
* Remove 9 second filter for early exit tests

* Change to AND

* Use IS FALSE
  • Loading branch information
cristinaleonr authored Feb 14, 2024
1 parent 7bc7ab8 commit 6a0f066
Showing 1 changed file with 3 additions and 1 deletion.
4 changes: 3 additions & 1 deletion views/ndt_intermediate/extended_ndt7_downloads.sql
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,8 @@ PreComputeNDT7 AS (

FinalSnapshot IS NOT NULL AS IsComplete, -- Not Missing any key fields

IF ("early_exit" IN (SELECT metadata.Name FROM UNNEST(raw.Download.ClientMetadata) AS metadata), True, False) AS IsEarlyExit,

-- Protocol
CONCAT("ndt7",
IF(raw.ClientIP LIKE "%:%", "-IPv6", "-IPv4"),
Expand Down Expand Up @@ -109,7 +111,7 @@ UnifiedDownloadSchema AS (
_IsRFC1918, -- Not a real client (deprecate?)
False AS IsPlatformAnomaly, -- FUTURE, No switch discards, etc
(FinalSnapshot.TCPInfo.BytesAcked < 8192) AS IsSmall, -- not enough data
(test_duration < 9000.0) AS IsShort, -- Did not run for enough time
(test_duration < 9000.0 AND IsEarlyExit IS FALSE) AS IsShort, -- Did not run for enough time (does not apply to early-exit tests)
(test_duration > 60000.0) AS IsLong, -- Ran for too long
_IsCongested,
_IsBloated
Expand Down

0 comments on commit 6a0f066

Please sign in to comment.