Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] New pandas versions seem to break Vis aggregation #492

Open
WillSealy opened this issue Mar 21, 2023 · 2 comments
Open

[BUG] New pandas versions seem to break Vis aggregation #492

WillSealy opened this issue Mar 21, 2023 · 2 comments

Comments

@WillSealy
Copy link

Describe the Bug
The merge call in the execute_aggregate function (lux -> executor -> PandasExecutor -> line 237) fails on pandas versions >1.4.4, which forces Lux to revert to pandas display and stops the widget from rendering. Guessing this has something to do with pandas 1.5.x changes to the groupby function.

To Reproduce

import pandas as pd
import lux
df = pd.read_csv("https://github.com/lux-org/lux-datasets/blob/master/data/car.csv?raw=true")
df.intent = ['Brand', 'Origin']
df

Line that fails: vis._vis_data = vis.data.merge(df,on=[columns[0], columns[1]],how="right",suffixes=["", "_right"],)

Screenshots
image

Debugging information

Package Versions

           Version      
    python        3.8.13
       lux         0.5.1
    pandas         1.5.0
 luxwidget        0.1.11
matplotlib         3.5.3
    altair         4.2.0
   IPython         8.5.0
 ipykernel        6.15.2
ipywidgets         8.0.2

jupyter_client 7.3.5
jupyter_core 4.11.1
jupyter_server not installed
jupyterlab not installed
nbclient not installed
nbconvert 5.4.1
nbformat 5.5.0
notebook 6.4.12
qtconsole 5.3.2
traitlets 5.4.0

Widget Setup

✅ Jupyter Notebook Running
✅ luxwidget is enabled

@fredthedead
Copy link

Getting the same error

@jona-sassenhagen
Copy link

Here is a minimally reproducible example:

import pandas as pd
import lux
pd.Series(range(100)).astype(str)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants