Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: use stable git references & differential output #861

Merged
merged 1 commit into from
Nov 7, 2023
Merged

ci: use stable git references & differential output #861

merged 1 commit into from
Nov 7, 2023

Conversation

huitseeker
Copy link
Contributor

@huitseeker huitseeker commented Nov 7, 2023 •
edited
Loading

  • avoids using git branches in CI : branches move, and the CI infra is likely to resolve the branch to the gh merge queue branch due to nested checkouts,
  • uses differential output in criterion-table for commit-comment.

Closes #858

@huitseeker
ci: use stable git references & differential output
3c62609 
- avoids using git branches in CI output (branches move!)
- uses differential output in criterion-table for commit-comment
@huitseeker huitseeker requested review from a team as code owners November 7, 2023 13:11
@huitseeker huitseeker added this pull request to the merge queue Nov 7, 2023
@samuelburnham samuelburnham mentioned this pull request Nov 7, 2023
Closed
Merged via the queue into lurk-lab:master with commit 0476f92 Nov 7, 2023
15 checks passed
@huitseeker huitseeker deleted the repair-ci branch November 7, 2023 15:09
This was referenced Nov 8, 2023
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samuelburnham samuelburnham samuelburnham approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CI: broken merge_group tests
2 participants
@huitseeker @samuelburnham