Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add tests for self-evaluating expressions #831

Merged
merged 2 commits into from
Nov 1, 2023
Merged

Add tests for self-evaluating expressions #831

merged 2 commits into from
Nov 1, 2023

Conversation

arthurpaulino
Copy link
Contributor

Closes #824

@arthurpaulino arthurpaulino requested review from a team as code owners November 1, 2023 16:44
@arthurpaulino arthurpaulino mentioned this pull request Nov 1, 2023
Closed
10 tasks
huitseeker
huitseeker reviewed Nov 1, 2023
View reviewed changes
Copy link
Contributor

@huitseeker huitseeker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove the concerned tests from circuit_frame.rs as well.

@huitseeker huitseeker mentioned this pull request Nov 1, 2023
Closed
huitseeker
huitseeker approved these changes Nov 1, 2023
View reviewed changes
Copy link
Contributor

@huitseeker huitseeker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thank you so much!

@arthurpaulino arthurpaulino added this pull request to the merge queue Nov 1, 2023
Merged via the queue into master with commit 8fe45e7 Nov 1, 2023
15 checks passed
@arthurpaulino arthurpaulino deleted the ap/more-lem-tests branch November 1, 2023 19:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@huitseeker huitseeker huitseeker approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Port the circuit_frame tests to LEM
2 participants
@arthurpaulino @huitseeker