Revert "merge fib benchmarks (#784)" #808
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 1ad6470.
arthurpaulino
approved these changes
Oct 27, 2023
johnchandlerburnham
approved these changes
Oct 27, 2023
samuelburnham
approved these changes
Oct 27, 2023
porcuquine
approved these changes
Oct 27, 2023
10 tasks
huitseeker
added a commit
to huitseeker/lurk-rs
that referenced
this pull request
Oct 30, 2023
- Enhanced identification and tracking for benchmarks by moving 'date' and 'sha' fields to `ProveParams` struct. - Tuned the `fibo_prove` function to utilize the new fields for better benchmark IDs (see lurk-lab#782) - Updated `rust-toolchain` version from `1.72.1` to `1.73.0` enhancing overall runtime environment. - Counted throughput in frames / s. This performs the straightforward parts of lurk-lab#782, re-opened after lurk-lab#784 was reverted (in lurk-lab#808)
huitseeker
added a commit
to huitseeker/lurk-rs
that referenced
this pull request
Oct 30, 2023
- Enhanced identification and tracking for benchmarks by moving 'date' and 'sha' fields to `ProveParams` struct. - Tuned the `fibo_prove` function to utilize the new fields for better benchmark IDs (see lurk-lab#782) - Updated `rust-toolchain` version from `1.72.1` to `1.73.0` enhancing overall runtime environment. - Counted throughput in frames / s. This performs the straightforward parts of lurk-lab#782, re-opened after lurk-lab#784 was reverted (in lurk-lab#808)
huitseeker
added a commit
to huitseeker/lurk-rs
that referenced
this pull request
Oct 31, 2023
- Enhanced identification and tracking for benchmarks by moving 'date' and 'sha' fields to `ProveParams` struct. - Tuned the `fibo_prove` function to utilize the new fields for better benchmark IDs (see lurk-lab#782) - Updated `rust-toolchain` version from `1.72.1` to `1.73.0` enhancing overall runtime environment. - Counted throughput in frames / s. This performs the straightforward parts of lurk-lab#782, re-opened after lurk-lab#784 was reverted (in lurk-lab#808)
huitseeker
added a commit
to huitseeker/lurk-rs
that referenced
this pull request
Oct 31, 2023
- Enhanced identification and tracking for benchmarks by moving 'date' and 'sha' fields to `ProveParams` struct. - Tuned the `fibo_prove` function to utilize the new fields for better benchmark IDs (see lurk-lab#782) - Updated `rust-toolchain` version from `1.72.1` to `1.73.0` enhancing overall runtime environment. - Counted throughput in frames / s. This performs the straightforward parts of lurk-lab#782, re-opened after lurk-lab#784 was reverted (in lurk-lab#808)
huitseeker
added a commit
to huitseeker/lurk-rs
that referenced
this pull request
Oct 31, 2023
- Enhanced identification and tracking for benchmarks by moving 'date' and 'sha' fields to `ProveParams` struct. - Tuned the `fibo_prove` function to utilize the new fields for better benchmark IDs (see lurk-lab#782) - Updated `rust-toolchain` version from `1.72.1` to `1.73.0` enhancing overall runtime environment. - Counted throughput in frames / s. This performs the straightforward parts of lurk-lab#782, re-opened after lurk-lab#784 was reverted (in lurk-lab#808)
huitseeker
added a commit
to huitseeker/lurk-rs
that referenced
this pull request
Oct 31, 2023
- Enhanced identification and tracking for benchmarks by moving 'date' and 'sha' fields to `ProveParams` struct. - Tuned the `fibo_prove` function to utilize the new fields for better benchmark IDs (see lurk-lab#782) - Updated `rust-toolchain` version from `1.72.1` to `1.73.0` enhancing overall runtime environment. - Counted throughput in frames / s. This performs the straightforward parts of lurk-lab#782, re-opened after lurk-lab#784 was reverted (in lurk-lab#808)
github-merge-queue bot
pushed a commit
that referenced
this pull request
Oct 31, 2023
* chore: Enhance benchmark setup and update rust-toolchain - Enhanced identification and tracking for benchmarks by moving 'date' and 'sha' fields to `ProveParams` struct. - Tuned the `fibo_prove` function to utilize the new fields for better benchmark IDs (see #782) - Updated `rust-toolchain` version from `1.72.1` to `1.73.0` enhancing overall runtime environment. - Counted throughput in frames / s. This performs the straightforward parts of #782, re-opened after #784 was reverted (in #808) * chore:clippy * fix: adjust test post toolchain update * fix: permute rc param and fib_n
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 1ad6470.
Replaces #807.