fix: Bring back the old fib benchmarks #807
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
winston-h-zhang
force-pushed
the
old-fib-benchmark
branch
from
861a91d to
1785a60
Compare
winston-h-zhang
force-pushed
the
old-fib-benchmark
branch
from
1785a60 to
1b33713
Compare
huitseeker
suggested changes
Oct 27, 2023
There was a problem hiding this comment.
Given we've seen the new benches hang for those of us with GPUs (that is, the LEM benches cannot be run), I think we should go with a full-on reversion (#808) rather than adding lurk-alpha on the side.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Temporarily bring back the old fibonacci benchmarks to validate Beta perf before finalizing. Also because the new benchmarks are behaving strangely.