Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a demo flag on the load command #806

Merged
merged 1 commit into from
Oct 31, 2023
Merged

Add a demo flag on the load command #806

merged 1 commit into from
Oct 31, 2023
+84 −22

Conversation

arthurpaulino
Copy link
Contributor

Adds a --demo flag to load files in demo mode.

This is better than the initial idea of a new command because it can reuse all the parameters that the load command already accepts.

Closes #757

@arthurpaulino arthurpaulino requested review from a team as code owners October 26, 2023 22:07
@arthurpaulino arthurpaulino mentioned this pull request Oct 27, 2023
Closed
10 tasks
huitseeker
huitseeker reviewed Oct 30, 2023
View reviewed changes
Copy link
Contributor

@huitseeker huitseeker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One question : is there a place where the meaning of "demo mode" is documented. As a Lurk user, where could I learn about it?

@arthurpaulino
Copy link
Contributor Author

I'm planning to document it in the user manual

@arthurpaulino arthurpaulino added this pull request to the merge queue Oct 31, 2023
Merged via the queue into master with commit ab4ff04 Oct 31, 2023
10 checks passed
@arthurpaulino arthurpaulino deleted the ap/demo-flag branch October 31, 2023 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samuelburnham samuelburnham samuelburnham approved these changes

@huitseeker huitseeker huitseeker approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement the demo command
3 participants
@arthurpaulino @huitseeker @samuelburnham