refactor: Refactor Ptr struct to generic with type Tag #651
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
huitseeker
force-pushed
the
fuse_cont_ptr
branch
from
2635228 to
a986db9
Compare
porcuquine
reviewed
Sep 5, 2023
porcuquine
previously approved these changes
Sep 5, 2023
huitseeker
force-pushed
the
fuse_cont_ptr
branch
from
a986db9 to
c714faa
Compare
- Refactored `Ptr` struct into a generic `GPtr` struct, introducing type parameter `T` and associating it with `Tag` interface. - Created `Ptr` and `ContPtr` types derived from `GPtr`. - Transferred pertinent predicate methods such as `is_nil`, `is_cons`, `is_atom`, `is_list`, `as_cons`, `as_list` to the new `GPtr<F, ExprTag>` implementation. - Transferred `ContPtr` struct and corresponding methods to `GPtr<F, ContTag>`. - No modifications made to `ExprTag` and associated enum elements in `tag.rs`. - Added `std::hash::Hash` trait to `Tag` interface in `tag.rs`.
huitseeker
force-pushed
the
fuse_cont_ptr
branch
from
c714faa to
298b981
Compare
porcuquine
approved these changes
Sep 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
In order to unify the current and LEM ways of defining the primary circuit and operating on it (so as to further #629), we need to abstract away a type that allows the developer to specify the associated types this circuit construction relies on. We started on this path with #644 and #647.
At a high level, each of the two implementations we have in mind for those traits define a single pointer type, rather than two. It would be ergonomic to have one.
The present PR defines
PtrandContPtras two distinct instantiations of a single pointer type, which is something we've wanted to do for a while already. We just needed an excuse.Details
Ptrstruct into a genericGPtrstruct, introducing type parameterTand associating it withTaginterface.PtrandContPtrtypes derived fromGPtr.GPtr,is_nil,is_cons,is_atom,is_list,as_cons,as_listtoGPtr<F, ExprTag>.ContPtrstruct and corresponding methods toGPtr<F, ContTag>.ExprTag/ContTagand associated enum elements intag.rs.std::hash::Hashtrait toTaginterface intag.rs.