Standardize logging with tracing crate + implement micro-benchmarking
#627
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
huitseeker
previously requested changes
Aug 28, 2023
There was a problem hiding this comment.
This just needs a bit of deduplication, back to your queue @winston-h-zhang
huitseeker
reviewed
Aug 29, 2023
There was a problem hiding this comment.
So this is starting to look egg-cellent! Thanks for the quick turnaround @winston-h-zhang
A couple of simpler comments inline, all around communicating what's going on, and which I think are needed to complete the "wow" effect of this PR, and then I think we can merge.
| @@ -153,7 +155,12 @@ enum Sha256Coproc<F: LurkField> { | |||
| /// Run the example in this file with | |||
| /// `cargo run --release --example sha256 1 f5a5fd42d16a20302798ef6ed309979b43003d2320d9f0e8ea9831a92759fb4b false` | |||
There was a problem hiding this comment.
Please annotate with the command that would allow printing the TexRay layer to stdout, and recall that command + the output in the PR summary for reviewers to easily get the point of the PR.
huitseeker
changed the title
tracing cratetracing crate + implement micro-benchmarking
- Removed `log` as a workspace dependency and replaced it with `tracing` throughout the project, - Updated clippy linting configuration in `.cargo/config`. - Adapted from `log` crate's `info` module to `tracing` crate's `info` module in `lurk-metrics/src/data.rs`
winston-h-zhang
force-pushed
the
hz/tracing
branch
from
7ab19fe to
6c6c1d8
Compare
huitseeker
approved these changes
Aug 29, 2023
emmorais
approved these changes
Aug 29, 2023
porcuquine
approved these changes
Aug 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #614.
We move away from
log/env_logger/dbg!and replace everything with the unifiedtracingecosystem. All the old logging infrastructure is still there, essentially with a drop in replacement oflog -> tracingandtracing_subscriber. Additionally, we add thetracing_texraycrate, with allows us to easily visualize spans and benchmarks of lurk. Texray can be enabled wherever and tracing offers a lot of flexibility; please see the documentation for more info (tracing, tracing-texray)Now running
creates the following pretty output (along with the normal
infolevel logs):