Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Drop OpenCL, and refactor Cargo.toml for workspace use #1046

Merged
merged 2 commits into from
Jan 12, 2024
Merged

chore: Drop OpenCL, and refactor Cargo.toml for workspace use #1046

merged 2 commits into from
Jan 12, 2024

Conversation

huitseeker
Copy link
Contributor

  • Refined GitHub GPU CI workflow by removing OpenCL Rust tests and enabling only CUDA tests
  • Revamped package settings to workspace level across the GitHub repository, implemented in lurk-macros, lurk-metrics and Cargo.toml
  • Removed specific dependencies pasta-msm and grumpkin-msm from Cargo.toml,
  • Reordered the features in Cargo.toml, removed opencl and some deps off portable for better maintainability
  • Cleaned up minor formatting issue in 'lurk-macros/src/lib.rs'

@huitseeker
chore: Drop OpenCL, and refactor Cargo.toml for workspace use
b92b2dc 
- Refined GitHub GPU CI workflow by removing OpenCL Rust tests and enabling only CUDA tests
- Revamped package settings to workspace level across the GitHub repository, implemented in `lurk-macros`, `lurk-metrics` and `Cargo.toml`
- Removed specific dependencies `pasta-msm` and `grumpkin-msm` from `Cargo.toml`,
- Reordered the features in `Cargo.toml`, removed `opencl` and some deps off `portable` for better maintainability
- Cleaned up minor formatting issue in 'lurk-macros/src/lib.rs'
@huitseeker huitseeker requested review from a team as code owners January 12, 2024 19:00
samuelburnham
samuelburnham previously approved these changes Jan 12, 2024
View reviewed changes
@huitseeker huitseeker enabled auto-merge January 12, 2024 19:51
@huitseeker huitseeker added this pull request to the merge queue Jan 12, 2024
github-actions bot pushed a commit that referenced this pull request Jan 12, 2024
@huitseeker @github-actions
[automated] GPU Benchmark from PR #1046
9f4ea20
Merged via the queue into lurk-lab:main with commit 9f8231e Jan 12, 2024
11 checks passed
@huitseeker huitseeker deleted the cleanup_dependencies branch January 12, 2024 20:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samuelburnham samuelburnham samuelburnham approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@huitseeker @samuelburnham