Chore: generalize the REPL field and enable BN256 #1017
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arthurpaulino
commented
Jan 4, 2024
arthurpaulino
changed the title
huitseeker
reviewed
Jan 4, 2024
* Remove the hardcoded Pallas field from the REPL * Enable the use of BN256/Grumpkin cycle
arthurpaulino
force-pushed
the
refactor-repl
branch
from
5c14852 to
10cf81b
Compare
arthurpaulino
added a commit
that referenced
this pull request
Jan 5, 2024
* Remove hardcoded Coproc occurrences from the REPL implementation * Use Coproc on the top-level call * Fix a non-generalized leftover from #1017
arthurpaulino
added a commit
that referenced
this pull request
Jan 5, 2024
* Remove hardcoded Coproc occurrences from the REPL implementation * Use Coproc on the top-level call * Fix a non-generalized leftover from #1017
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jan 5, 2024
* Remove hardcoded Coproc occurrences from the REPL implementation * Use Coproc on the top-level call * Fix a non-generalized leftover from #1017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses the second item of #533