Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Post-#706] Improve TOML config file UX #793

Open
samuelburnham opened this issue Oct 24, 2023 · 0 comments
Open

[Post-#706] Improve TOML config file UX #793

samuelburnham opened this issue Oct 24, 2023 · 0 comments
Labels
DX-DevEx Developer Experience track

Comments

@samuelburnham
Copy link
Contributor

Doc comment for CliSettings:

// NOTE: Config settings share the same file for both the Lurk library and the CLI.
// It's good practice to avoid duplication of shared settings like public_params_dir
// in downstream configs like these to prevent conflicts.

From #706 (comment):

This is a bit confusing, as a user-specified rc and limit value in the config file will affect the CLI but not the Lurk library or benchmarks as one might expect. It may be more user-friendly to have a separate cli.toml rather than sharing settings with lurk.toml, or better yet support a table-based TOML structure like the following:

[lurk]
public_params_dir = "/path/to/public_params"

[cli]
proofs_dir = "/path/to/proofs"
rc = 100
limit = 100000000
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DX-DevEx Developer Experience track
Projects
None yet
Development

No branches or pull requests

1 participant