Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

end2end benches run with duplicate Store types #787

Closed
samuelburnham opened this issue Oct 24, 2023 · 0 comments · Fixed by #788
Closed

end2end benches run with duplicate Store types #787

samuelburnham opened this issue Oct 24, 2023 · 0 comments · Fixed by #788

Comments

@samuelburnham
Copy link
Contributor

Since #774 we no longer run benches with blstrs::Scalar. In end2end.rs and end2end_lem.rs we still run comparative benchmarks with a bls_store and pallas_store, but they are the same type.

Either we should restore the blstrs::Scalar as Fr import or dispense with the bls_store benchmark (I think the latter?).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant