Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor circuit generation for benchmarking #390

Closed
winston-h-zhang opened this issue May 4, 2023 · 3 comments
Closed

Refactor circuit generation for benchmarking #390

winston-h-zhang opened this issue May 4, 2023 · 3 comments
Labels
P-Performance Performance track

Comments

@winston-h-zhang
Copy link
Contributor

winston-h-zhang commented May 4, 2023

This benchmark is not benchmarking what it claims to right now, I think. get_evaluation_frames doesn't actually synthesize the circuits. I may be misunderstanding though, and I'd like to have a better idea of what's going on in these steps. However, I'm a bit stuck since it looks like the synthesis/proving is happening at the same time? What should be done here?

Originally posted by @winston-h-zhang in #380 (comment)

@huitseeker
Copy link
Contributor

@porcuquine Would appreciate you having a look at the commented code in #380:
https://github.com/lurk-lab/lurk-rs/pull/380/files#r1185193258
and adding your thoughts on the best way to proceed here.

@huitseeker huitseeker added the P-Performance Performance track label May 4, 2023
@huitseeker
Copy link
Contributor

@winston-h-zhang this should be made obsolete by our synthesis bench, I think?

@huitseeker
Copy link
Contributor

Closed in #415

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P-Performance Performance track
Projects
None yet
Development

No branches or pull requests

2 participants