ci: Customize benchmark PR comment action #1071
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR benchmark comment customization
This PR enables customization of the
issue_comment
PR comment action from directly within the!gpu-benchmark
comment. We can now run multiple benchmarks, with customizable features and env vars. The initial format is as follows:Implementation notes
boa-dev/criterion-compare-action
only being able to run one benchmark or all of them (the latter with some hacks).bench.env
file used byjust
in favor of user specification in the commentcuda
feature once implemented, as it's hardcoded here.Limitations
awk
script, which should be improved in future work.Successful run
https://github.com/lurk-lab/ci-lab/actions/runs/7580695577