Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

All hands on deck - Spring cleaning update issues thread #138

Open
lupuleasa-core opened this issue Mar 25, 2016 · 65 comments
Open

All hands on deck - Spring cleaning update issues thread #138

lupuleasa-core opened this issue Mar 25, 2016 · 65 comments

Comments

@lupuleasa-core
Copy link
Owner

Spring cleaning broke a lot of things apparently, and I'll reserve the time to do some fixing.

Please report whatever is not working here.

I got plenty of comments on reddit:

Related threads:
#137

@lupuleasa-core
Copy link
Owner Author

I'll be home in 6 hours or so.

@ubobob
Copy link

ubobob commented Mar 25, 2016

Ok things I noticed so far looking very quickly

Middle mouse button grab not working.
Switching between auto attack on and off not working
Some problem with quick cast/ normal cast.

There may be more problems I'll see if I can find.

In the meantime some things that would be nice to have.

Cycling between all 3 auto attack options that we have now.
integration of the new spawn box and tower range indicators with some other useful stuff.
Integration of new camera bind option etc.

Thanks a lot! Really appreciate your efforts man.

@Acerecon
Copy link

Great summary @ubobob I think you covered most of the experiences people have been having that I've been reading except the inclusion of using chat. It seems that a setting was added to be able to change the hotkey for chat and it's mucked everything up.

There's definitely some interesting avenues to explore as far as integrating options to utilize the new location binding ability as well.

One lost think to note is the settings menu/options has been revamped so idk if that might change what needs to be in the autoexec just something to be aware of @loopuleasa

Agreed, these keybinds are the only way I can even play anymore so i'm pushing to be helpful in any way to try and get them fixed.

@lupuleasa-core
Copy link
Owner Author

With the new officially supported per-hero binds, will there be any need for our .cfg custom hero system. Anyone know how to integrate both of them?

@Sembrani
Copy link
Contributor

I'll look into it, but I can't get to it for a while. If anyone else wants to do it, have at it.

@pledbrook
Copy link

The dota_ability_quickcast n command still exists, but doesn't seem to do anything. You need to set dota_ability_quick_cast true|false and then use dota_ability_execute n. I wouldn't be surprised if this doesn't change soon.

Item quick cast just seems to be broken in the game right now.

@lupuleasa-core
Copy link
Owner Author

I will do my best to get it done by tomorrow.
@Sembrani you deserve a break tbh 👍
Good job so far handling the work while I was busy

@FlorianWendelborn
Copy link
Contributor

I'm quite sure we shouldn't ditch hero bindings yet, since the game still doesn't support modifier keys

@Aevyz
Copy link
Contributor

Aevyz commented Mar 25, 2016

@ubobob You can fix the middle mouse by using "bind mouse3 +cameragrip" however it only lasts until you Alt Tab (could not find out why that is)
Also, chat is broken too, can't identify why right now

@knipsis
Copy link

knipsis commented Mar 25, 2016

not even till you Alt Tab, but just till you push Alt, i have written bind mouse3 +cameragrip in my config, but re-exec autoexec doesnt fix camera grip issue

@knipsis
Copy link

knipsis commented Mar 25, 2016

writing in console manually fixes till you use the different alternative keybinds

@knipsis
Copy link

knipsis commented Mar 25, 2016

i think the problem is in the unbind command on top of different keybinds, tho i can't understand why changing back to keybindings_default doesn't resolve the issue, because that is where i put the bind

@FlorianWendelborn
Copy link
Contributor

@knipsis there is a way to not use unbindall, however, it's a little bit ugly and takes quite some time when doing it by hand.

@Aevyz
Copy link
Contributor

Aevyz commented Mar 25, 2016

@knipsis Temporary Fix:

Go to C:\Program Files (x86)\Steam\steamapps\common\dota 2 beta\game\dota\cfg\dota2_gameplay_mode\dota2_keybinds_default.cfg

And add "bind mouse3 +cameragrip" at the end (after unbindall). It should work

@silencer666
Copy link

Hi. My issue is very severe, it is not just the mouse3 issue

I can't cast any spells or use any items without holding ALT down and then clicking

I can't even choose spells upgrades

EDIT: I fiddled with OPTION SCREEN and resolved the above.

Stuff that doesn't work:

  • Enter key does not work. Thus no chat.
  • Toggle Autoattack enabled/disabled. The corresponding text appears, but autoattack is never really enabled.

Autocast on/off [Space + Z]

Can't choose spell upgrades

QWER doesn't quickcast

DFXCV doesn't quickcast

EDIT: Sorry for being a bit stupid.

@grasdaggel
Copy link

Chatwheel tilts my mouse to the left side of the screen and linked chat message is displayed onscreen. Not sure if this came trough Spring Update to be honest, tho.

@FlorianWendelborn
Copy link
Contributor

Your autoexec Most likely just doesn't load. Type exec autoexec.cfg in console

@knipsis
Copy link

knipsis commented Mar 25, 2016

@AetherV that is how i binded, but still after pushing either Alt or Space it doesn't work, executing autoexec.cfg during game doesn't fix it, only rebinding in console till next Alt or Space or relaunching Dota

@FlorianWendelborn
Copy link
Contributor

Try to remove all occurrences of unbindall, it will lead to some weird behavior, but it should be fine most of the time.

@Aevyz
Copy link
Contributor

Aevyz commented Mar 25, 2016

@knipsis That is strange, works fine by me, but then again, I think I'm on an outdated version of the config. Can you show me your dota2_keybinds_default.cfg file.

@Aevyz
Copy link
Contributor

Aevyz commented Mar 25, 2016

@silencer666 For

Can't choose spell upgrades

What exactly do you mean. The CTRL+Q/W/E/R skilling? The Learn Ability Bind? Clicking on spells?

@knipsis
Copy link

knipsis commented Mar 25, 2016

@AetherV under camera commands

////////////////////////////////////////////////////////////////////////////
//Reverting to default keyboard commands
////////////////////////////////////////////////////////////////////////////

//Remove all leftover keybinds
unbindall

//Fix an issue with Chat Wheel
-chatwheel

//Fix an issue with Score Screen
-showscores

//Show the console
bind \ toggleconsole

//Selecty hero
bind 1 +dota_camera_follow

//The micromanagement section
bind 2 +dota_control_group 1
bind 3 +dota_control_group 2
bind 4 +dota_control_group 3
bind 5 +dota_control_group 4
bind 6 +dota_control_group 5
bind 7 +dota_control_group 6
bind 8 +dota_control_group 7
bind 9 +dota_control_group 8
bind 0 +dota_control_group 9
bind TAB dota_cycle_selected

//Learn stats.
bind H dota_learn_stats

//Inspect hero
bind I inspectheroinworld

//Stop key
bind S dota_stop

//Camera movements
bind mouse3 +cameragrip
bind KP_2 +back
bind KP_4 +moveleft
bind KP_6 +moveright
bind KP_8 +forward

//Chat
bind KP_ENTER say
bind ENTER say

//Action items or taunts
bind [ use_item_client player_loadout action_item
bind ] use_item_client current_hero taunt

//Function keys
bind F2 dota_select_courier
bind F3 dota_courier_deliver
bind F4 dota_purchase_quickbuy
bind F5 gameui_activate
bind F6 dota_toggle_combatlog
bind F8 exec autoexec.cfg
bind F9 dota_pause
bind F12 jpeg

//Enter the mode to learn an ability
bind Y dota_ability_learn_mode

//Shop
bind B toggleshoppanel

//Voice chat
bind CAPSLOCK +voicerecord

//Go to recent event/ping
bind Z dota_recent_event;

////////////////////////////////////////////////////////////
//Custom Shit
////////////////////////////////////////////////////////////

//Make SPACE be a modifier key
bind SPACE +keyShift

//Make ALT be a modifier key
bind ALT +keyShift2

//Bind F7 as the quick/normal cast toggle switch
bind F7 quick_normal_cast_toggle

//Mode toggled (Quick or Normal cast) cast for items
bind mouse5 toggle_enabled_use_item_0
bind D toggle_enabled_use_item_1
bind F toggle_enabled_use_item_2
bind mouse4 toggle_enabled_use_item_3
bind X toggle_enabled_use_item_4
bind C toggle_enabled_use_item_5

//Mode toggled (Quick or Normal cast) cast for abilities
bind Q toggle_enabled_use_ability_0
bind W toggle_enabled_use_ability_1
bind E toggle_enabled_use_ability_2
bind T toggle_enabled_use_ability_3
bind G toggle_enabled_use_ability_4
bind R toggle_enabled_use_ability_5

//Load the primary cast mode keys for abilities and items
load_primary_cast_mode

//A for attack move, instead of A + Click
bind A mc_attack; +sixense_left_click; -sixense_left_click

// Shuffle camera to rune positions while pressing the keys and back to hero on release
bind F1 +rune

//Missing Script and other communications
//(binds the arrow keys to call missing, not as useful with the chat wheel thing but I prefer it still)
bind J chatwheel_say 7
bind K chatwheel_say 8
bind N chatwheel_say 2
bind M chatwheel_say 44
bind , chatwheel_say 57
bind . chatwheel_say 53

//Camera grip custom key
bind KP_5 +cameraControl;

// Bind a key to enable/disable the net graph
bind F10 custom_toggle_netgraph

// Bind F11 to enable/disable developer debug output
bind F11 custom_toggle_developer

////////////////////////////////////////////////////////////
//Custom Hero Mode binds
////////////////////////////////////////////////////////////

//Load the hero binds for the hero toggled currently
load_current_hero_nomod_binds

@knipsis
Copy link

knipsis commented Mar 25, 2016

i couldn't add *.cfg file, because it isn't supported

@FlorianWendelborn
Copy link
Contributor

There is https://gist.github.com though.

@Aevyz
Copy link
Contributor

Aevyz commented Mar 25, 2016

@knipsis
This is what I did: http://pastebin.com/9wwV94v3 (Default+One line at bottom)

@knipsis
Copy link

knipsis commented Mar 25, 2016

ok, thx will try

@grasdaggel
Copy link

Any updates on camera grip? Does the hotfix for the camera grip work, can this anyone confirm?

@KaiSforza
Copy link
Contributor

@AetherV the weird part is that in the dotakeys_personal.lst that is the action it's assigned.

"ChatTeam"
{
    "Name" "ChatTeam"
    "Action" "say"
    "Key" "KP_ENTER"
    ...
}

@Acerecon
Copy link

@AetherV I was able to use your fork and the drag mouse work around seems to have worked. Fantastic. Now we just need to figure out chat.

@phar0ah
Copy link

phar0ah commented Mar 26, 2016

re: bind enter say

I believe the command for chat has not changed, but rather the way configs/commands input via console are parsed by the client has changed, strangely this does not seem to be the case for all commands but only some.

This can be observed when entering

dota_camera_disable_zoom "1" into the console which will return the error
Error parsing value to set configuration value "dota_camera_disable_zoom" to (""1"")!

note that the additional quotation marks around the value 1 are the source of the problem and removing them allows the command to be executed correctly.

Meanwhile inputting a few variablew with quotation marks does work e.g.
dota_friendly_color_r "0.13" still executes with no issues whether you use quote marks around the value or omit them.

I wonder if quotation marks are added around automatically around variables where they are expected now, and this is causing an issue in the case of commands where the number of arguments presented to the command is expected to change the output.

The say, say_team and say_student commands with an argument of "string" should output that string to the correct channel without further user input, however those commands when receiving zero arguments are expected to open an input field for the user to provide the "string" to be sent.

So when we execute via console or config a bind {key} say is this now being interpreted as
bind {key} say "" and executed as if we have sent a command to say emptystring rather than a say with no string input at all?

This might explain why it appears that the command is bound correctly in dotakeys_personal.lst and why say "specifiedstring" commands do work but say alone does not.

I assume that the way that keys are bound via the config menu somehow bypasses this form of interpretation which is why this issue only occurs for those using the console/config to configure their chat key.

Been looking for another way to force the appearance of the chat entry input field but still no luck so far.

If this is the cause of the problem with binding the say commands to a key, is anyone here good with the dev forums and able to get it looked at?

@rothor
Copy link

rothor commented Mar 26, 2016

They just made an update:

  • Fixed various bugs with quickcast on key up sometimes not working with items
  • Fixed being unable to explicitly bind a key to chat

:')

@phar0ah
Copy link

phar0ah commented Mar 26, 2016

HIP HIP HOORAY! (sorry for spamming e-mails with that useless comment I got too excited about the chat binding fix).

@lupuleasa-core
Copy link
Owner Author

A fix for what is left (middle mouse drag, auto attack toggle) is currently being deployed.

Thank you volvo. You fucked up this time.

@brave46
Copy link

brave46 commented Mar 26, 2016

So there is no console command for camera grip?

@Aevyz
Copy link
Contributor

Aevyz commented Mar 26, 2016

EDIT: I am blind, Loop updated his config. Should all work now

@brave46 There is, namely +cameragrip. Its just volvo broke the way the config was written. Camera grip fix should be up as soon as loop fixes a few problems with my pull. If you need it fixed now, try using my fork (and update to loop's config as soon as he does his stuff)

@lupuleasa-core
Copy link
Owner Author

Everything seems to be working fine.
Thanks everyone.

@rodrunordie
Copy link

Could you notice here when command to toggle autoattack on/off is realased. Thanks so much.

@Aevyz
Copy link
Contributor

Aevyz commented Mar 27, 2016

@rodrunordie it is partially there. Problem is valve changed a few commands and I don't think it can be implemented like it was before (specifically the combining of aa after spell and aa). I'll be tinkering around with the script to see if I can improve what we currently have.

@dssrtfx
Copy link

dssrtfx commented Mar 27, 2016

@loopuleasa So just re-download the config for fixes?

@EpsilonDSC
Copy link

Hey I installed the new files, but my spells and item won't work. I can only self cast things after I enable double tap to selfcast and the new smart double tap options in the advance settings.

@lupuleasa-core
Copy link
Owner Author

@EpsilonDSC
Double Tap selfcast must be enabled (it is already enabled in the files)

@dsrtfx
yes

@silencer666
Copy link

hi guys. Can anyone here get autoattack toggle to work properly?

@lupuleasa-core
Copy link
Owner Author

Let me test that again @silencer666

@rodrunordie
Copy link

@AetherV I had the command to switch autoatack on to off ingame. Autoatack afterspell was always on for becasue I like to have it on. So the new command should be something to switch from autoattack never to autoatack standard, but don´t know how should be written. Thanks.

@lupuleasa-core
Copy link
Owner Author

Auto-attack toggle works fine to me.

@rodrunordie
Copy link

@loopuleasa Could you share the autoatack toggle please? Mine is not working after Spring cleaning

@EpsilonDSC
Copy link

Something are working for me and something aren't. Would someone please upload the current visuals of the key binds to imgur because Windows keeps telling me that my copy of the PNGs are damaged/corrupted and I'd like to give a complete assessment.

@FlorianWendelborn
Copy link
Contributor

@EpsilonDSC you can browse the source code on GitHub and view them there.

@Aevyz
Copy link
Contributor

Aevyz commented Mar 27, 2016

Wait you also have the PNG problem... I thought that was isolated to me. Anyhow, nothing should have changed hotkey wise, so the pngs on github (which are viewable) should be right.

@rodrunordie just update your config. Update was pushed yesterday so if you d/l it again and replace the files it should work. If you have custom settings, you can manually make the changes to the two text files.

@rodrunordie
Copy link

@AetherV @loopuleasa Thanks, got it, it´s working perfectly,

@EpsilonDSC
Copy link

@dodekeract @AetherV Thanks, I wasn't aware I could do that.
Also should have read the thread more clearly, @liltobe9 posted a fix that worked for me.
Thanks everyone.

@FlorianWendelborn
Copy link
Contributor

Are you sure you modified the right files? DotA has two config/autoexec folders. Many people make that mistake.

@intabli
Copy link

intabli commented Mar 28, 2016

Edit: Fixed now, thank you for your help dodekeract.

@FlorianWendelborn
Copy link
Contributor

Is it possible that spring cleaning changed how autoexec can set stickybuy too? I'm currently trying to implement custom buy hotkeys for Manta and tried to use this:

hud_sticky_item_name item_reaver

Doesn't work, any ideas? If possible I'd like to avoid that shop-hotkey hack.

EDIT: Also it seems to be impossible to purchase secret-shop-only items using that shop-hotkey hack. (reaver, etc.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests