Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please add to the FS API (Metadata) #251

Open
bbslipers opened this issue Sep 3, 2024 · 2 comments
Open

Please add to the FS API (Metadata) #251

bbslipers opened this issue Sep 3, 2024 · 2 comments
Labels
enhancement New feature or request

Comments

@bbslipers
Copy link

Please add to Metadata for files: size and MD5.

@CompeyDev
Copy link
Contributor

CompeyDev commented Sep 3, 2024

Size is possible to add, but I don't see why we would want to add MD5 hashes. The filesystem itself returns no data for hashing, so we'd need to calculate it ourselves - which doesn't make much sense when you can just use serde.hash.

Do note that serde itself does not contain the MD5 algorithm on purpose, since it's insecure and prone to hash collisions.

@bbslipers
Copy link
Author

Thanks for the reply. You are absolutely right about MD5 hashes. I was out of my depth.

@filiptibell filiptibell added the enhancement New feature or request label Sep 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants