Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Installer wants to know whether to overwrite existing config #22

Open
glennjacobs opened this issue Mar 29, 2022 · 6 comments
Open

Installer wants to know whether to overwrite existing config #22

glennjacobs opened this issue Mar 29, 2022 · 6 comments
Assignees

Comments

@glennjacobs
Copy link
Contributor

Not sure what the correct thing to do is? Is the commited config changed from default?

@alecritson
Copy link
Contributor

There's a few changes such as order statuses, payment stuff and a bit on the cart I think.

@glennjacobs
Copy link
Contributor Author

Any suggestions on how to solve this? As people will overwrite them for sure...

@alecritson
Copy link
Contributor

Add a command to run i.e. demostore:install instead which does the GetCandy install but then copies across the config we need?

@glennjacobs
Copy link
Contributor Author

My only concern with that is the developer isn't getting familiar with the getcandy command.

What if we run the demostore:install command after the getcandy one? Yes, it's an extra step.. but they're learning.

@alecritson
Copy link
Contributor

Yeah, seems reasonable. Will see If I can get a PR done.

@glennjacobs
Copy link
Contributor Author

@alecritson I see you closed your PR on this. Is this still an issue? If someone overwrites the config, will it cause uses on the demo store?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants