Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reconcile loop cannot recover from event pointing to an object that doesn't exist #50

Open
GuyMoses opened this issue Jul 13, 2023 · 0 comments
Labels
bug Something isn't working

Comments

@GuyMoses
Copy link
Collaborator

Describe the bug
the reconcile loop cannot recover from event pointing to an object that doesn't exist

To Reproduce

  1. create a namespace and add the operator to that namespace
  2. create a deployment with a bad name (e.g. use an underscode in the name) in that namespace
  3. see the deployment failing to create
  4. fix the deployment name and deploy it
  5. the operator fails to inject

Expected behavior
the operator should be able to inject once the deployment is fixed

Runtime details

  • tried on python3.9

Screenshots
kubectl logs

The Deployment "unicorn_analytics" is invalid: metadata.name: Invalid value: "unicorn_analytics": a lowercase RFC 1123 subdomain must consist of lower case alphanumeric characters, '-' or '.', and must start and end with an alphanumeric character (e.g. 'example.com', regex used for validation is '[a-z0-9]([-a-z0-9]*[a-z0-9])?(\.[a-z0-9]([-a-z0-9]*[a-z0-9])?)*')

operator logs

2023-07-13T10:04:04Z    ERROR   controllers.Lumigo      Cannot rebind dangling LumigoAddedInstrumentation event '0xc000748a60'  {"name": "lumigo", "namespace": "unicorns-rainbows", "error": "cannot fill out the 'InvolvedObject' reference: cannot retrieve 'unicorns-rainbows/unicorn_analytics' Deployment: deployments.apps \"unicorn_analytics\" not found"}
github.com/lumigo-io/lumigo-kubernetes-operator/controllers.(*LumigoReconciler).Reconcile
        /workspace/controllers/lumigo_controller.go:290
sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).Reconcile
        /go/pkg/mod/sigs.k8s.io/[email protected]/pkg/internal/controller/controller.go:122
sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).reconcileHandler
        /go/pkg/mod/sigs.k8s.io/[email protected]/pkg/internal/controller/controller.go:323
sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).processNextWorkItem
        /go/pkg/mod/sigs.k8s.io/[email protected]/pkg/internal/controller/controller.go:274
sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).Start.func2.2
        /go/pkg/mod/sigs.k8s.io/[email protected]/pkg/internal/controller/controller.go:235

Additional context
Add any other context about the problem here.

@GuyMoses GuyMoses added the bug Something isn't working label Jul 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant