From a09d2fb8a2905a965a7c6b325ae85e44b949bd27 Mon Sep 17 00:00:00 2001
From: Oscar Otero <oom@oscarotero.com>
Date: Mon, 9 Oct 2023 19:13:39 +0200
Subject: [PATCH] fixed metas plugin

---
 CHANGELOG.md                           | 4 ++++
 plugins/metas.ts                       | 5 -----
 tests/__snapshots__/metas.test.ts.snap | 9 ---------
 3 files changed, 4 insertions(+), 14 deletions(-)

diff --git a/CHANGELOG.md b/CHANGELOG.md
index 13746ffb..c1ee9f94 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -10,6 +10,10 @@ Any BREAKING CHANGE between minor versions will be documented here in upper case
 ### Added
 - The second argument of the `page.data.url()` function has the default URL value.
 
+### Changed
+- Removed schema.org meta tags in metas plugin, because they are are not valid.
+  Probably it needs a new specific plugin.
+
 ### Fixed
 - Ignore error checking Lume version in offline environments [#496].
 - Updated dependencies: `deno_dom`, `katex`, `preact`, `sass`, `svg2png`, `terser`.
diff --git a/plugins/metas.ts b/plugins/metas.ts
index e4a5791e..257bd8f8 100644
--- a/plugins/metas.ts
+++ b/plugins/metas.ts
@@ -112,11 +112,6 @@ export default function (userOptions?: Partial<Options>): Plugin {
       );
       addMeta(document, "name", "twitter:site", twitter);
 
-      // Schema.org
-      addMeta(document, "itemprop", "name", title);
-      addMeta(document, "itemprop", "description", description, 155);
-      addMeta(document, "itemprop", "image", image || icon);
-
       // SEO
       addMeta(document, "name", "description", description, 155);
       addMeta(document, "name", "keywords", keywords?.join(", "));
diff --git a/tests/__snapshots__/metas.test.ts.snap b/tests/__snapshots__/metas.test.ts.snap
index 2fef8c63..12c6b73f 100644
--- a/tests/__snapshots__/metas.test.ts.snap
+++ b/tests/__snapshots__/metas.test.ts.snap
@@ -101,9 +101,6 @@ snapshot[`metas plugin 3`] = `
 <meta property="og:image" content="http://localhost/my-image.png">
 <meta name="twitter:card" content="summary_large_image">
 <meta name="twitter:site" content="@myUser">
-<meta itemprop="name" content="Custom title">
-<meta itemprop="description" content="A very long custom description with a lot of text that will be truncated to a maximum of 155 characters and then append &quot;…&quot; to the end. Lorem ipsum dolor…">
-<meta itemprop="image" content="http://localhost/my-image.png">
 <meta name="description" content="A very long custom description with a lot of text that will be truncated to a maximum of 155 characters and then append &quot;…&quot; to the end. Lorem ipsum dolor…">
 <meta name="keywords" content="one, two">
 <meta name="robots" content="index, follow">
@@ -179,9 +176,6 @@ snapshot[`metas plugin 3`] = `
 <meta property="og:image" content="http://localhost/page-2/my-image.png">
 <meta name="twitter:card" content="summary_large_image">
 <meta name="twitter:site" content="@myUser">
-<meta itemprop="name" content="Relative paths">
-<meta itemprop="description" content="Tests the use of relative path (to page.data.url) when filling out the og:image or og:icon URL">
-<meta itemprop="image" content="http://localhost/page-2/my-image.png">
 <meta name="description" content="Tests the use of relative path (to page.data.url) when filling out the og:image or og:icon URL">
 <meta name="keywords" content="one, two">
 <meta name="robots" content="noindex, nofollow, noarchive">
@@ -256,9 +250,6 @@ snapshot[`metas plugin 3`] = `
 <meta property="og:image" content="http://localhost/page-3/use-cover-as-meta-image.png">
 <meta name="twitter:card" content="summary_large_image">
 <meta name="twitter:site" content="@myUser">
-<meta itemprop="name" content="Title from page data">
-<meta itemprop="description" content="This is page excerpt will be used as meta description.">
-<meta itemprop="image" content="http://localhost/page-3/use-cover-as-meta-image.png">
 <meta name="description" content="This is page excerpt will be used as meta description.">
 <meta name="keywords" content="one, two">
 <meta name="robots" content="this robots will be overrided">