Fix/thinking aloud #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CallumGrindle
approved these changes
Jan 22, 2024
fix: Repair caching of lukso api calls. fix: Also adjust code which is getting the name fix: Disable refresh and stale handling. fix: Make it stale for 1 hours. fix: Remove lookup for 0x0000...0000 address on the api fix: Prevent flickering from one icon to another.
richtera
force-pushed
the
fix/thinking-aloud
branch
from
c65394b to
d8687ad
Compare
richtera
force-pushed
the
fix/thinking-aloud
branch
from
d8687ad to
114d468
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description and Related Issue(s)
Caching for api.universalprofile.cloud is not ideal and the browser many times tries
to get information for the same address due to useEffect and useState re-rendering.
Proposed Changes
Change to use useQuery instead of manually using the query client.
Additional Information
The change should be observable in the network panel of the browser debugger.
Checklist for PR author