Merge pull request #192 from jmarcher/master

Merge with #190
lukepolo · May 3, 2017 · 8ff7fc1 · 8ff7fc1
2 parents 191234a + 5ec5980
commit 8ff7fc1
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/src/Traits/CartOptionsMagicMethodsTrait.php b/src/Traits/CartOptionsMagicMethodsTrait.php
@@ -54,8 +54,8 @@ public function __set($option, $value)
                 }
                 break;
             case CartItem::ITEM_TAX:
-                if (!empty($value) && (!is_numeric($value) || $value > 1)) {
-                    throw new InvalidTaxableValue('The tax must be a float less than 1');
+                if (!empty($value) && (!is_numeric($value))) {
+                    throw new InvalidTaxableValue('The tax must be a number');
                 }
                 break;
             case CartItem::ITEM_TAXABLE:

diff --git a/tests/MagicFunctionsTest.php b/tests/MagicFunctionsTest.php
@@ -31,10 +31,10 @@ public function testSet()
         $this->assertEquals(123, $item->test_option);
 
         try {
-            $item->tax = 2;
+            $item->tax = 'not_a_number';
             $this->setExpectedException(InvalidTaxableValue::class);
         } catch (InvalidTaxableValue $e) {
-            $this->assertEquals('The tax must be a float less than 1', $e->getMessage());
+            $this->assertEquals('The tax must be a number', $e->getMessage());
         }
 
         try {