Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set default activation of committor model back to tanh #138

Closed
EnricoTrizio opened this issue May 27, 2024 · 0 comments · Fixed by #145
Closed

Set default activation of committor model back to tanh #138

EnricoTrizio opened this issue May 27, 2024 · 0 comments · Fixed by #145
Assignees
Labels
bug Something isn't working

Comments

@EnricoTrizio
Copy link
Collaborator

EnricoTrizio commented May 27, 2024

After #135, the activation of hidden layers of the Committor class is no longer set to tanh as the default, which should be the proper choice.

For the moment, this can be circumvented by setting

options = { 'nn' : { 'activation' : 'tanh' }}
model = Committor(..., options=options, ...)

This should be fixed soon.

@EnricoTrizio EnricoTrizio added the bug Something isn't working label May 27, 2024
@EnricoTrizio EnricoTrizio self-assigned this May 27, 2024
EnricoTrizio added a commit that referenced this issue Jun 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant