Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove underscore in activation functions #136

Open
EnricoTrizio opened this issue May 21, 2024 · 0 comments
Open

Remove underscore in activation functions #136

EnricoTrizio opened this issue May 21, 2024 · 0 comments
Labels
question Further information is requested

Comments

@EnricoTrizio
Copy link
Collaborator

EnricoTrizio commented May 21, 2024

In a future release, should we remove the underscore from custom activation classes Custom_Sigmoid and Shifted_Softplus?

From #135

I see, thanks. In principle, if Shifted_Softplus was in a previous release, we'd have to deprecate it and remove it only when we'll release 2.0. If that's the case, we could just change their name and do

class Shifted_Softplus(ShiftedSoftplus):
    def __init__(...):
        warn('Shifted_Softplus is deprecated use ShiftedSoftplus instead.')
        super().__init__(...)
@EnricoTrizio EnricoTrizio added the question Further information is requested label May 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

1 participant