Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SecureChannelFailure: The request was aborted #20

Open
haidelber opened this issue Jan 4, 2019 · 1 comment
Open

SecureChannelFailure: The request was aborted #20

haidelber opened this issue Jan 4, 2019 · 1 comment

Comments

@haidelber
Copy link

It seems this plugin (System.Net.WebRequest) uses TLS 1.0 to connect to download Favicons. As TLS 1.0 is vulnerable it's disabled on many webservers (https://www.globalsign.com/en/blog/disable-tls-10-and-all-ssl-versions/).
This is the reason for the majority of my new entries not being able to download favicons which is a bit annoying. As MS docs suggests System.Net.Http.HttpClient should be used now but this is only available from .Net 4.5.
Would you accept a pull request lifting the .Net framework requirement to 4.5 or should I rather fork?

@haidelber
Copy link
Author

It seems it can be fixed by setting the TLS version manually as well: https://support.microsoft.com/en-gb/help/3154517/support-for-tls-system-default-versions-included-in-the-net-framework#section-2

haidelber added a commit to haidelber/KeePass-Favicon-Downloader that referenced this issue Jan 4, 2019
haidelber added a commit to haidelber/KeePass-Favicon-Downloader that referenced this issue Jan 6, 2019
haidelber added a commit to haidelber/KeePass-Favicon-Downloader that referenced this issue Jan 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant