Skip to content

Latest commit

 

History

History
executable file
·
33 lines (21 loc) · 2.38 KB

cran-comments.md

File metadata and controls

executable file
·
33 lines (21 loc) · 2.38 KB

20.01.2025

  • does not yet compile without errors on macos-arm64, because the ontologics pacakges hasn't been updated there yet.

03.07.2023

11.05.2023

  • fix return value of matchOntology() and updateTable()
  • check that no functions/examples/tests write into the home directory of a user
  • update broken link in README.md
  • ensure local checks throw no error '--as-cran', with devtools::check_win_devel() and with devtools::check_rhub() to ensure that the errors for which the package was archived are fixed. All are largely positive (some NOTES). There is currently a bug on github actions with one of the linux packages that is out of my reach, so that I don't get a positive response via the github actions https://github.com/luckinet/arealDB/actions/runs/4936161250/jobs/8823363476#step:6:4042

30.06.2020

  • mention 'suppressMessages' in the documentation, as all output to the console is provided with "message()", this can easily be suppressed.
  • improve examples so that they show the full range of functions. Therefore I wrote the function "makeExampleDB", which carries out building the example database until a certain point, so that not everything has to be typed in.
  • use tempdir() in 'makeExampleDB'.

19.06.2020

  • most examples require \dontrun{} as they build on one-another, i.e., setPath() is run to specify a location where the database should be established and only then setVariables() can be run to create the respective index and translation tables. Same with regDataseries(), regGeometry() and regTable(), which store the information into the respective folders and with the norm*() functions, which pick up those data and normalise them. To ensure that all functions are tested properly, I set up unit-tests that go through this whole procedure. As a simple example, this would be too much, as it would require for each functions deeper into the process an increasingly longer list of code, and it would anyway take (much) longer than 5 seconds to execture.

29.05.2020

  • set 'arealDB' in DESCRIPTION in single quotes
  • change format of arXiv reference in DESCRIPTION
  • be more explicit about what the function returns for 'setPath', 'setVariables', 'normGeometry', 'normTable' and 'translateTerms'
  • use on.exit(oldOptions) in 'setPath' to reset options to the status of before this function was called.