Skip to content
This repository has been archived by the owner on Jul 7, 2021. It is now read-only.

Supervisor and Caddy 2 #14

Open
johandalabacka opened this issue Dec 15, 2019 · 10 comments
Open

Supervisor and Caddy 2 #14

johandalabacka opened this issue Dec 15, 2019 · 10 comments

Comments

@johandalabacka
Copy link

Hi. More of a question than an issue. How are your plans to support Caddy 2?

@mholt
Copy link

mholt commented Dec 16, 2019

FWIW, I'd be interested in collaborating on an official (i.e. in the caddyserver organization) module for process supervision in Caddy 2. A lot of new and interesting possibilities here.

@lucaslorentz
Copy link
Owner

@mholt
That's very nice.
I can update the readme page with links to the new module, let me know when you have a repo for it.

@Baldinof
Copy link

Baldinof commented Jan 8, 2021

Hi!

Is there any plans on this?

I really enjoyed this plugin on caddy v1 :)

@lucaslorentz if you don't have time / plan for it I think I could find some time to work on this.

@mholt are you still OK to make this an official module?

@lucaslorentz
Copy link
Owner

@Baldinof
I wasn't planning to work on it anytime soon.
But I can help you if you need any assistance.

@lucaslorentz lucaslorentz reopened this Jan 8, 2021
@mholt
Copy link

mholt commented Jan 8, 2021

are you still OK to make this an official module?

Yeah, we can depending on its popularity/usefulness -- I don't have much spare bandwidth to collaborate right now though. (My earlier comment was from well over a year ago!) The only difference is where the code lives, any repo will do - there's no technical difference.

Would be cool to see one!

@DanyHenriquez
Copy link

DanyHenriquez commented Jan 27, 2021

@mholt I have read the documentation and think i can do this. I would make a PR this weekend with a simple implementation to monitor a process

@Baldinof
Copy link

Baldinof commented Jan 27, 2021

Hi!

I totally forgot to respond here, I was planning to make a PR too but I don't know when I will find the time to finish it.

For the logging part, I think the processes outputs could be written in a specific log field. This way it could be sent to stdout / stderr via something like this:

log {
  format single_field "supervisor_stdout"
}

@mholt
Copy link

mholt commented Jan 27, 2021

(FWIW I intend to deprecate the single_field log encoder sooner or later.)

@DanyHenriquez
Copy link

DanyHenriquez commented Jan 28, 2021

So i see we want to use supervisor lib for this. Is there any library which has already been decided on?

@mholt
Copy link

mholt commented May 5, 2021

Remind me to upload some pictures I took of the Windows Task Scheduler this last week. (I'm waiting for GitHub to fix EXIF stripping before I post them here.) I think it has a lot of useful customization options that could be good inspiration for this kind of module.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants