Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Catch unknown characters in read_fhx() #206

Open
chguiterman opened this issue Aug 15, 2023 · 1 comment
Open

Catch unknown characters in read_fhx() #206

chguiterman opened this issue Aug 15, 2023 · 1 comment
Labels
bug Something isn't working

Comments

@chguiterman
Copy link
Contributor

If there is an unknown character in an FHX file, burnr throws an error from an internal function burnr:::abrv2rec():

Error in rec_type_all[[as.character(x)]] : subscript out of bounds

We should implement an informed error for these cases, ideally identifying where in the file it was found
@brews brews added the bug Something isn't working label Aug 21, 2023
@brews
Copy link
Member

brews commented Aug 21, 2023

Thank you for the issue! Is there a reproducible example for this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@brews @chguiterman