Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

intervals() calculates negative means on long chronologies #204

Open
chguiterman opened this issue Mar 29, 2023 · 1 comment
Open

intervals() calculates negative means on long chronologies #204

chguiterman opened this issue Mar 29, 2023 · 1 comment
Labels
bug Something isn't working

Comments

@chguiterman
Copy link
Contributor

Based on how R sorts years when their length changes, composite() places pre-1000 CE dates after post-1000 CE dates. This results in intervals() calculating negative (and totally erroneous besides) intervals. For example,
image
The second column are years, and note that the year 817 CE comes after 1879 CE. This results in -1062 year interval...

To fix it, I'll sort the years entering intervals()

@brews
Copy link
Member

brews commented Mar 29, 2023

Man, thanks for catching this, @chguiterman 👍

@brews brews added the bug Something isn't working label Mar 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants