Making new release (4.93.3) #96

masatake · 2020-06-05T00:18:33Z

We have so many changes. Let's make a release.

TODO in this release (easy):

(abort):

man page issue (man page is not built for Linux dialect and does not work on its own #66, Build man page for linux using soelim. #67, and file .ck00MAN should not be in the tree #93?)

(done):

merge [linux] Allow reproducible builds #94
merge [FreeBSD] Merge freebsd patches #97
update 00CREDITS
revise 00DISTS
remove "Masatake YAMATO" at the end of 00DISTS should be remove.
establish the procedures and process for releasing

masatake · 2020-06-05T00:19:55Z

The version number will be 4.93.3.
Till documentation cleanup is done, we should not release 4.94.x.

lrosenman · 2020-06-05T00:34:39Z

What's going to be the criteria for making new releases going forward?

I've got #95 to update the Cirrus Images, and then I want to get all the local patches I have in the FreeBSD ports tree up here and then cut a new release.

I'm also going to see if I can convince some of the FreeBSD kernel folks to modernize all the FreeBSD dialect-specific stuff.

lrosenman · 2020-06-05T00:35:58Z

And what is the process to make a new release tag/etc?

masatake · 2020-06-05T00:43:15Z

What's going to be the criteria for making new releases going forward?

About the criteria for the time of releasing?

We should make a release at least every year if we have any change.
If one of us wants, we will make a release in a month.
If there is a security issue, we should do the best.
...

I've got #95 to update the Cirrus Images, and then I want to get all the local patches I have in the FreeBSD ports tree up here and then cut a new release.

Could you do it in this June? If the answer is yes, let's include the change.
If not, let's make a new release (4.93.4) in July. In the case, I would like you to open an issue for releasing.

About the process, I wrote it somewhere but I cannot remember. I will search it.

lrosenman · 2020-06-05T00:46:44Z

#95 is ready to go (It WILL fail CI till the other patches are done).

I can get the other patches in this weekend.
see https://svnweb.freebsd.org/ports/head/sysutils/lsof/files/ for all the patches I have against the current release.

do you want one big PR to get current or multiple PR's for each issue as I found them?

masatake · 2020-06-05T01:03:26Z

If you change the code common in dialects, I would like you to make separate SMALL pull requests
(or git commits) with enough commit log. @filbo, and I will review the impact of the change for
the common code on the other dialects. The review should be done in...two weeks.
If the reviewer doesn't respond in two weeks, let's go forward.
@filbo, how do you think this process?
"two weeks" is too short?

If the change is not for common code, please, do as you want.
Even a change is for a specified dialect, I would like you to keep following two things:

adding the description of user-visible change to 00DISTS, and
updating 00CREDIT.

lrosenman · 2020-06-05T01:06:56Z

see #97.

masatake · 2020-06-05T01:14:52Z

I think the first line of a commit log has following format:

   [dialect] description...

This can also be an header of item of 00DISTS.

e.g.

commit 46d831d18b00aa9c5d1f6eff921a20a5534494e1 (origin/update-netlink-protocols, update-netlink-protocols)
Author: Masatake YAMATO <[email protected]>
Date:   Wed Dec 25 18:20:51 2019 +0900

    [linux] decode more netlink protocol numbers (RDMA, CRYPTO, and SMC)
    
    Signed-off-by: Masatake YAMATO <[email protected]>

This commit log can be found in 00DISTS:

[linux] decode more netlink protocol numbers (RDMA, CRYPTO, and
                SMC).

This doesn't mean all the commits should be enumerated in 00DISTS.
Only user-visible change should go to 00DISTS.

If a commit log doesn't have [dialect] prefix, it implies the change for the code common in dialects.
So the other maintainers must take time for reviewing it.

masatake · 2020-06-05T01:18:11Z

The changes proposed in #96 is done by you?
If not, we should the person who worked for lsof should be listed in 00CREDIT.

lrosenman · 2020-06-05T01:19:36Z

They were from a bunch of FreeBSD committers.
I'll have to look to see who all submitted the patches to me (as FreeBSD port maintainer).

masatake · 2020-06-05T01:24:44Z

Yes, please. it takes your time however, putting the name of the contributor to 00CREDIT is only what we can do for the contributions.

masatake · 2020-06-05T01:25:49Z

Please, don't be hurry. We can make a release in every time we want.

lrosenman · 2020-06-05T01:27:38Z

Done. (The names / id's were in the SVN logs at FreeBSD).

masatake · 2020-06-07T04:54:33Z

Release criteria of timing:

one of dialect maintainers (@lrosenman, @filbo, and @masatake) can propose any time one wants.
Open an issue for releasing like this issue.
the proposer can propose a new version number.
if none responds to the proposal in a month, the proposer makes a release.
if someone responds to it, we should make a realistic TODO list for the releasing, and work hard for solving them. The items in the list should be fixed about two months. If it is not possible, the item should not be in the list. Dropping the item from the list is acceptable.
When all the items are fixed/solved, it is time for releasing. The proposer should take the action.
we should make a least per year at least as far as there is a change in our repository.

I cannot find the list of procedures for releasing. I will make a beta version to remember the procedures. I will summarize the procedures later.

masatake · 2020-06-07T04:59:26Z

@lrosenman, @filbo, do you have any item you want to add the TODO list.
I will pick up the item if you write it in a comment.

lrosenman · 2020-06-08T15:45:39Z

None at the moment.

masatake · 2020-06-10T20:17:13Z

@lrosenman, thank you.

masatake · 2020-10-03T19:22:19Z

Very sorry to be late. I also fix #102 and #103.

masatake · 2020-11-05T15:40:14Z

I found scripts support/LinuxDistrib and support/FreeBSDistrib.
With modification, LinuxDistrib works well. I think we can use them. With the result, we can generate dialect-specific tarballs.
I will explore more.

masatake · 2020-11-10T19:38:46Z

So many changes have been introducd since the last release. So I decide the version of next release is 4.94.0.
I made a pre-release. See https://github.com/lsof-org/lsof/releases. I will convert the pre-release to a release in soon.

I wrote how to make a release. I will put this note to our git repo after releasing.

0. Install ksh
========================================================================

The script for making an archive needs ksh.


1. Implement "make dist" for your favorite dialect
========================================================================

See https://github.com/lsof-org/lsof/pull/131 how @masatake does for
linux dialect.

Merge the changes.


2. Update the version and release date in the source tree if you need
========================================================================

See git log 7412e7445377c0f629c1ecb2eecfd14255935c7d.

The version number has following form MAJOR.MINOR.MICRO.  When making a
release, update the version number.  If the change from the last release
is small, increment MICRO. If it is large, increment MINOR.

Merge the changes.

If you just want to make a release for a version already released in
another dialect, you don't need this step. Relase the version number.

e.g.

     conditions and situations:
     @masatake already released 4.94.0 for linux.
     No uesr visible change is commited to our git repo.
     You may want to make the same release but for dialect freebsd.

     In this case, you can use 4.94.0 as the version number.  If the
     condition doesn't meet, use 4.94.1 (or 4.95.0).


3. Make the source archive for the release
=======================================================
::

   $ ./Configure [dialect]
   $ make dist

The archive is put at support/ directory.

Checking whether you can build a lsof executable from the archive is
good idea.

e.g.
::

   $ cp support/support/lsof_4.94.0.linux.tar.bz2
   $ cd /tmp
   $ tar jxvf lsof_4.94.0.linux.tar.bz2
   $ cd lsof_4.94.0.linux
   $ ./Configure linux
   $ make
   $ make check (if your dialect support the target)

4. Visit https://github.com/lsof-org/lsof/releases
========================================================================

4.1 Click [Draft new release]
------------------------------------------------------------------------

4.2 Fill the fields
------------------------------------------------------------------------

4.2.1 Fill "Tag version"
........................................................................

Fill with the version number given in th step 2.

4.2.2 Fill "Release title"
........................................................................

Use the following form lsof-${theVersionNumber}-${dialect}.

e.g. lsof-4.94.0-linux

4.2.3 Fill "Describe this release"
........................................................................

Copy and paste the changes described in 00DIST since the last release in
your dialect.

4.2.4 Put the source archive generaeted step in 3.
........................................................................

Click "Attach binaries by dropping them here or selecting them. ", then
specify the archive file.

4.2.5 Check "This is a pre-release"
........................................................................

4.2.6 Click [Publish release]
........................................................................

5. Verify the release
========================================================================

After step 4.2.6, the browser may show the page for the release. You can
re-read the description and the source code archives. You can verify
what you did here.

If you find a fault or something, click the [Edit] in the page. You can
update the pre-release.

If you convince it is ready, click the [Edit] in the page, remove the
check at "This is a pre-release", then [Publish release]. The new
version is available at https://github.com/lsof-org/lsof/releases.

masatake · 2020-11-10T19:58:03Z

See #134.

masatake changed the title ~~Making new release~~ Making new release (4.93.3) Jun 5, 2020

masatake mentioned this issue Jun 5, 2020

Fails to build on FreeBSD PowerPC64 #69

Closed

masatake mentioned this issue Nov 10, 2020

Define the criteria for making a new release? #54

Closed

masatake closed this as completed Nov 10, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Making new release (4.93.3) #96

Making new release (4.93.3) #96

masatake commented Jun 5, 2020 •

edited

Loading

masatake commented Jun 5, 2020

lrosenman commented Jun 5, 2020

lrosenman commented Jun 5, 2020 •

edited

Loading

masatake commented Jun 5, 2020

lrosenman commented Jun 5, 2020

masatake commented Jun 5, 2020

lrosenman commented Jun 5, 2020

masatake commented Jun 5, 2020

masatake commented Jun 5, 2020

lrosenman commented Jun 5, 2020

masatake commented Jun 5, 2020

masatake commented Jun 5, 2020

lrosenman commented Jun 5, 2020

masatake commented Jun 7, 2020

masatake commented Jun 7, 2020

lrosenman commented Jun 8, 2020

masatake commented Jun 10, 2020

masatake commented Oct 3, 2020

masatake commented Nov 5, 2020

masatake commented Nov 10, 2020

masatake commented Nov 10, 2020

Making new release (4.93.3) #96

Making new release (4.93.3) #96

Comments

masatake commented Jun 5, 2020 • edited Loading

masatake commented Jun 5, 2020

lrosenman commented Jun 5, 2020

lrosenman commented Jun 5, 2020 • edited Loading

masatake commented Jun 5, 2020

lrosenman commented Jun 5, 2020

masatake commented Jun 5, 2020

lrosenman commented Jun 5, 2020

masatake commented Jun 5, 2020

masatake commented Jun 5, 2020

lrosenman commented Jun 5, 2020

masatake commented Jun 5, 2020

masatake commented Jun 5, 2020

lrosenman commented Jun 5, 2020

masatake commented Jun 7, 2020

masatake commented Jun 7, 2020

lrosenman commented Jun 8, 2020

masatake commented Jun 10, 2020

masatake commented Oct 3, 2020

masatake commented Nov 5, 2020

masatake commented Nov 10, 2020

masatake commented Nov 10, 2020

masatake commented Jun 5, 2020 •

edited

Loading

lrosenman commented Jun 5, 2020 •

edited

Loading