Bugfix: Fix adding members to conversation
#167
+6
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FelberMartin
approved these changes
Nov 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem Description
There was an issue that prevented users from adding members to a conversation. Instead of adding the members, an error was shown.
Changes
The cause of this error was a missing conversation id that ensures a match to the correct conversation. The manage_conversations_module has been changed to correctly set the conversationId parameter of the ConversationAddMembersViewModel. This PR fixes #139.
In Conversation AddMemberSettingsE2eTest, the functionality of adding members is tested. However, this bug did not affect the tests as the conversationId is set independently from the module there.
Steps for testing
Add membersAdd