Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Programming Exercise: Git diff between template and solution shows incorrect number of changes #9928

Open
maximiliansoelch opened this issue Dec 2, 2024 · 2 comments · May be fixed by #9984
Open

Programming Exercise: Git diff between template and solution shows incorrect number of changes #9928

maximiliansoelch opened this issue Dec 2, 2024 · 2 comments · May be fixed by #9984
Assignees
@magaupp
Labels
bug exercise Pull requests that affect the corresponding module programming Pull requests that affect the corresponding module

Comments

@maximiliansoelch
Copy link
Member

maximiliansoelch commented Dec 2, 2024 •
edited
Loading

Describe the bug

For some files, the calculated numbers of additions and deletions are incorrect displayed.

To Reproduce

  1. Go to a programming exercise edit page
  2. Click on 'Review Changes' in the Template/Solution Comparison section
  3. Look for a file where the calculated number of additions and deletions is incorrect

Expected behavior

The number of added and deleted lines of code between the template and the solution submission should be correct.

Screenshots

image

Which version of Artemis are you seeing the problem on?

7.7.3

What browsers are you seeing the problem on?

Chrome, Safari

Additional context

No response

Relevant log output

No response
@github-actions github-actions bot added assessment Pull requests that affect the corresponding module exercise Pull requests that affect the corresponding module programming Pull requests that affect the corresponding module labels Dec 2, 2024
@maximiliansoelch maximiliansoelch removed the assessment Pull requests that affect the corresponding module label Dec 2, 2024
@github-actions github-actions bot added assessment Pull requests that affect the corresponding module lecture Pull requests that affect the corresponding module labels Dec 2, 2024
@magaupp magaupp self-assigned this Dec 3, 2024
@magaupp
Copy link
Contributor

magaupp commented Dec 5, 2024

@maximiliansoelch I wasn't able to reproduce your example. Could you provide the full files?

@maximiliansoelch maximiliansoelch removed assessment Pull requests that affect the corresponding module lecture Pull requests that affect the corresponding module labels Dec 6, 2024
@maximiliansoelch
Copy link
Member Author

@maximiliansoelch I wasn't able to reproduce your example. Could you provide the full files?

I provided you the details over Slack

This was referenced Dec 6, 2024
Closed
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@magaupp magaupp

Labels
bug exercise Pull requests that affect the corresponding module programming Pull requests that affect the corresponding module
Projects
None yet
Milestone
No milestone
2 participants
@maximiliansoelch @magaupp