Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quiz exercises: Edit button is disabled in exercise groups list #9865

Open
Hialus opened this issue Nov 25, 2024 · 4 comments · May be fixed by #9917
Open

Quiz exercises: Edit button is disabled in exercise groups list #9865

Hialus opened this issue Nov 25, 2024 · 4 comments · May be fixed by #9917
Labels
bug exam Pull requests that affect the corresponding module exercise Pull requests that affect the corresponding module lecture Pull requests that affect the corresponding module quiz Pull requests that affect the corresponding module

Comments

@Hialus
Copy link
Member

Hialus commented Nov 25, 2024

Describe the bug

When you are in the list of exercise groups of an exam, the edit button for quiz exercises is disabled.

To Reproduce

  1. Create an exam
  2. Create an exercise group
  3. Create a quiz exercise in this exercise group
  4. Go to the list of exercise groups
  5. See that the button is disabled

Expected behavior

The button is not disabled

Screenshots

image

Which version of Artemis are you seeing the problem on?

develop

What browsers are you seeing the problem on?

Chrome

Additional context

No response

Relevant log output

No response

@Hialus Hialus added the bug label Nov 25, 2024
@github-actions github-actions bot added exam Pull requests that affect the corresponding module exercise Pull requests that affect the corresponding module lecture Pull requests that affect the corresponding module quiz Pull requests that affect the corresponding module labels Nov 25, 2024
@laxerhd
Copy link

laxerhd commented Nov 27, 2024

While the exam is active, the edit button is disabled by default. There is also a comment in the code:
<!-- Only show the edit button if the exam has not ended. Disable the button if the exam is running -->
I'm not sure if we want to remove this protection mechanism? Please provide feedback.
In the event that we actually would want to edit questions during the exam, I can gladly create a PR that makes the button clickable during exams.

@krusche
Copy link
Member

krusche commented Nov 28, 2024

We need to keep this protection mechanism. Editing a quiz while someone is actively working on it, is not supported, because it can lead to database inconsistencies. This also applies for test runs of instructors during the quiz setup.

The reason is that during editing, you could easily delete answer options that are already references in submitted answers.

We could potentially allow some kind of limited edit support (similar to re-evaluate), but this is not easy to implement and currently out of scope.

@laxerhd
Copy link

laxerhd commented Nov 28, 2024

I believe it is still possible to edit the quiz even though the button is disabled. You can access the editing website via the href of the “edit” button. Should we also stop the user from this?
We could also add a tooltip or something similar stating that editing is not possible while the exam is open to provide clarity to the user.

@laxerhd
Copy link

laxerhd commented Dec 13, 2024

Hey @Hialus,
I can also see that other people might think the disabled edit button is a bug,
so I've added a tooltip explaining to them why it's disabled. It would be great if you could review the PR for me
as it only spans a few lines.
Thanks ;D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug exam Pull requests that affect the corresponding module exercise Pull requests that affect the corresponding module lecture Pull requests that affect the corresponding module quiz Pull requests that affect the corresponding module
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants