Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invalidate GitHub cache so that embeddings are not cached #123

Merged
merged 1 commit into from
Dec 9, 2024

Conversation

farisd16
Copy link
Member

@farisd16 farisd16 commented Dec 9, 2024

When returning a diagram, headers are set in the response so that the GitHub's CDN cache is invalidated. This ensures that diagram embeddings are not cached and therefore always up to date.

Idea from https://stackoverflow.com/a/27893930

Copy link
Contributor

@FelixTJDietrich FelixTJDietrich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as expected
image

@FelixTJDietrich FelixTJDietrich merged commit 754f296 into main Dec 9, 2024
6 checks passed
@FelixTJDietrich FelixTJDietrich deleted the enhancement/invalidate-github-cache branch December 9, 2024 22:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants