Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Inline table edits do not persist if original value is null #1299

Open
1 task done
lanedsmu opened this issue Nov 12, 2024 · 1 comment
Open
1 task done

[Bug]: Inline table edits do not persist if original value is null #1299

lanedsmu opened this issue Nov 12, 2024 · 1 comment

Comments

@lanedsmu
Copy link

Is there an existing issue for this?

  • I have searched the existing issues

Current Behavior

When editing a value in a table, the editing works as expected if there is a value already in that cell. If, however, the original value is null, that field reverts to null after typing a value in it. There isn't any value to save, therefore.

Expected Behavior

Edited fields should allow changing from null->value just as when changing an existing value

Steps to reproduce

create a table, with some cells having null values. Mark those as editable.
When editing those null values, the new value doesn't "stick"

Environment

self-hosted docker multi v2.4.12

Additional Information

No response

@jnewman-eti
Copy link

jnewman-eti commented Nov 13, 2024

Also related to data having null values: as of 2.4.12, some tables in our apps have stopped selecting rows if data backing the table is null. This is a difficult issue to reproduce, because when the data is static the table works fine.

This is the console error that is produced when this happens. No rows except the first row are able to be selected.

If we remap the interpolated variable that holds the data by making sure null values are converted to empty string, then this issue goes away. This is not a feasible solution to this problem, and needs to be picked up.

index-4f883cee.js:855 Uncaught TypeError: Cannot convert undefined or null to object
at Function.keys ()
at index-4f883cee.js:855:680
at Map.forEach ()
at t.fetchInfo (index-4f883cee.js:855:518)
at a_n (index-4f883cee.js:832:24221)
at n.value [as fetchInfo] (index-4f883cee.js:832:24403)
at t.fetchInfo (index-4f883cee.js:832:27040)
at a_n (index-4f883cee.js:832:24221)
at n.value [as fetchInfo] (index-4f883cee.js:832:24403)
at index-4f883cee.js:832:28275

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants