Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FBCache design considerations #16

Closed
alphaville opened this issue Jan 18, 2016 · 1 comment
Closed

FBCache design considerations #16

alphaville opened this issue Jan 18, 2016 · 1 comment

Comments

@alphaville
Copy link
Collaborator

Why do we store m_res1_rows and m_res1_cols as private fields in FBCache? Since we store m_L1 we can retrieve them from there any time we like. The same holds for m_x (we store m_x_rows and m_x_cols).

Further, we don't even need to store m_L1, m_f1, etc. This is why you introduced FBProblem as a field in FBCache. We have the constructor FBCache(FBProblem & p, Matrix & x, double gamma); so we can retrieve a reference to an FBProblem and store it internally and this will be it.

I believe we can/should refactor FBCache and simplify it.

alphaville added a commit that referenced this issue Jan 19, 2016
Removed from FBCache all unncessary private fields
Issue #16: closed
Removed file Makefile-Netbeans
Addressed some cppcheck warnings in test files
Added method template norm_fro_sq in Matrix.h
@alphaville
Copy link
Collaborator Author

Done in 59cd77c, but:

  1. there are still a few issues such as FBCache unnecessary allocation #21
  2. the documentation is not complete
  3. I believe m_status < FBCache::STATUS_FORWARD is not very safe
  4. A good part of FBCache is not tested

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants