You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Why do we store m_res1_rows and m_res1_cols as private fields in FBCache? Since we store m_L1 we can retrieve them from there any time we like. The same holds for m_x (we store m_x_rows and m_x_cols).
Further, we don't even need to store m_L1, m_f1, etc. This is why you introduced FBProblem as a field in FBCache. We have the constructor FBCache(FBProblem & p, Matrix & x, double gamma); so we can retrieve a reference to an FBProblem and store it internally and this will be it.
I believe we can/should refactor FBCache and simplify it.
The text was updated successfully, but these errors were encountered:
Removed from FBCache all unncessary private fields
Issue #16: closed
Removed file Makefile-Netbeans
Addressed some cppcheck warnings in test files
Added method template norm_fro_sq in Matrix.h
Why do we store
m_res1_rows
andm_res1_cols
as private fields inFBCache
? Since we storem_L1
we can retrieve them from there any time we like. The same holds form_x
(we storem_x_rows
andm_x_cols
).Further, we don't even need to store
m_L1
,m_f1
, etc. This is why you introducedFBProblem
as a field inFBCache
. We have the constructorFBCache(FBProblem & p, Matrix & x, double gamma);
so we can retrieve a reference to anFBProblem
and store it internally and this will be it.I believe we can/should refactor
FBCache
and simplify it.The text was updated successfully, but these errors were encountered: