Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge contents of this tutorial into the officlal pyhf tutorial? #1

Open
kratsg opened this issue Dec 12, 2023 · 2 comments
Open

Merge contents of this tutorial into the officlal pyhf tutorial? #1

kratsg opened this issue Dec 12, 2023 · 2 comments

Comments

@kratsg
Copy link
Collaborator

kratsg commented Dec 12, 2023

./cc @matthewfeickert

@lorenzennio
Copy link
Owner

If you feel like it fits, I would be happy to contribute.

@matthewfeickert
Copy link

While I'm in favor in general of having more things in the user guide, especially things that come from oustide ATLAS, I think for this tutorial there are things that are new and things that are complimentary to what already exists in https://github.com/pyhf/pyhf-tutorial/tree/d1a01df59cc9a4f1707020a77df6a424f1a556fe.

My suggestion would be twofold:

  1. Compare the notebooks that compliment existing things in the pyhf user guide/tutorial and then make a tracking Issue there summarizing what components in these notebooks extend the user guide and then we can work to harmonize things and get these extensions in.
  2. The "new" notebooks would be very interesting to add, but at the moment focus on using cabinetry and/or using data that isn't public. I think that I'd suggest working with Alex to contribute cabinetry specific workflows to https://github.com/cabinetry/cabinetry-tutorials (though to be clear I think we should add some "You want to do X with pyhf but it is a bit beyond the scope so here's how you use cabinetry to do X" examples to the pyhf user guide). For the things that use non-public data I would suggest trying to either get public samples or making a variation of the notebook that uses on the fly generated simulation that can be used and then we add this to the user guide.

Does this make sense? (I'm typing while thinking here)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants