Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rviz does not build in noetic and melodicPython3 #227

Closed
lelongg opened this issue Nov 22, 2022 · 4 comments · Fixed by #245
Closed

rviz does not build in noetic and melodicPython3 #227

lelongg opened this issue Nov 22, 2022 · 4 comments · Fixed by #245

Comments

@lelongg
Copy link

lelongg commented Nov 22, 2022

rviz fails to build with the following error

-- Found PythonInterp: /nix/store/xcaaly5shfy227ffs8nipxrd49b56iqq-python3-3.10.8/bin/python3 (found suitable version "3.10.8", minimum required is "3.10") 
CMake Warning at /nix/store/9fcvq10d1i5xy2v5gkhjyycv322w94j2-ros-noetic-python-qt-binding-0.4.4-r1/share/python_qt_binding/cmake/sip_helper.cmake:28 (message):
  SIP binding generator NOT available.
Call Stack (most recent call first):
  src/python_bindings/sip/CMakeLists.txt:42 (include)


-- Python binding generators: 
CMake Error at src/python_bindings/CMakeLists.txt:9 (message):
  No Python binding generator found.


-- Configuring incomplete, errors occurred!

reproducible with nix build github:lopsided98/nix-ros-overlay#noetic.rviz

@lopsided98
Copy link
Owner

There's not much I can do about this. The latest versions of Qt5 are no longer compatible with SIP 4, so I switched to Shiboken/PySide2 (see #224). This fixed rqt, but rviz is not compatible with PySide2, see: ros-visualization/rviz#1526

@natto1784
Copy link
Contributor

natto1784 commented Dec 18, 2022

Thanks for maintaining all of the distros! Do you suggest anything that might help with building rviz?
edit: i ended up just compiling everything from an older commit, using the following inputs

      ros.url = github:lopsided98/nix-ros-overlay/6fa03dc558b92cf7f3a2d426c9335e014e3fd10d;
      ros.inputs.nixpkgs.follows = "nixpkgs";
      nixpkgs.url = github:nixos/nixpkgs/release-22.05;

@kjeremy
Copy link
Contributor

kjeremy commented Feb 7, 2023

I'm running into this too. Maybe we can pin rviz to an older version from nix-ros-overlay?

@natto1784
Copy link
Contributor

Using this patch along with the old python-qt-binding override works with SIP4. I tested it as a global overlay for all distros and rviz compiled! Let's see if we can use this here for noetic and melodic specifically while using shiboken/pyside2 for other distros.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants