Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fio: add iostat and keep the output files #6

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Vicente-Cheng
Copy link

  • that we can do more investigation with these output files

For example, we will get the output like the following.

harvester-node-2:~ # ls output/
Local-Path-bandwidth-iostat.log  Local-Path-iops.json           Local-Path_vs_Longhorn.summary  Longhorn-iops-iostat.log     Longhorn-latency.json
Local-Path-bandwidth.json        Local-Path-latency-iostat.log  Longhorn-bandwidth-iostat.log   Longhorn-iops.json
Local-Path-iops-iostat.log       Local-Path-latency.json        Longhorn-bandwidth.json         Longhorn-latency-iostat.log

We could compare iostat data between Local-Path and Longhorn for further investigation.

  - that we can do more investigation with these output files

Signed-off-by: Vicente Cheng <[email protected]>
@Vicente-Cheng Vicente-Cheng force-pushed the add-iostat-and-keep-result branch from 527ec3d to 3ebe45c Compare November 20, 2023 15:09
@yasker
Copy link
Member

yasker commented Nov 22, 2023

Why do we need iostat here? FIO already has the categorized results.

And it's not a good idea to bind mount a host directory just to copy the files out, since the privilege would need to be escalated.

@Vicente-Cheng
Copy link
Author

Hi @yasker, thanks for the review.
We need the iostat data because we could do further investigation.
Sometimes, the performance issue will related to the physical device.
Through the device queue length, request size, wait time ... etc. We can get more info to figure out the performance issue.

@yasker
Copy link
Member

yasker commented Nov 22, 2023

I see. A few comments here:

  1. Is there a way for us to figure out the block device without specifying it manually?
  2. Does it work if we pass in the block devices directly (see volumeDevices section)?
  3. Can we find another way to get those outputs without requiring an elevated privilege?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants