Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add real size to backing image #313

Merged

Conversation

ChanYiLin
Copy link
Contributor

ref: longhorn/longhorn#8757

  • get realsize of the backing image by using syscall
  • store realsize of backingimage in status and return to the caller (longhorn-manager/backing-image-controller)

@ChanYiLin ChanYiLin self-assigned this Aug 26, 2024
@ChanYiLin ChanYiLin requested review from shuo-wu and derekbit August 26, 2024 10:55
Copy link

mergify bot commented Aug 26, 2024

This pull request is now in conflict. Could you fix it @ChanYiLin? 🙏

@ChanYiLin ChanYiLin force-pushed the LH8757_record_backing_image_real_size branch from 2a1e68d to 6379c44 Compare August 27, 2024 08:19
@ChanYiLin
Copy link
Contributor Author

This pull request is now in conflict. Could you fix it @ChanYiLin? 🙏

fixed.

@ChanYiLin
Copy link
Contributor Author

Pending

Wait for longhorn/type PR: longhorn/types#26

@ChanYiLin ChanYiLin force-pushed the LH8757_record_backing_image_real_size branch from 6379c44 to ff144ac Compare August 27, 2024 08:27
@ChanYiLin ChanYiLin force-pushed the LH8757_record_backing_image_real_size branch from ff144ac to fabe6d3 Compare August 27, 2024 09:18
Copy link

mergify bot commented Aug 28, 2024

This pull request is now in conflict. Could you fix it @ChanYiLin? 🙏

@ChanYiLin ChanYiLin force-pushed the LH8757_record_backing_image_real_size branch 2 times, most recently from 75011e6 to 57b0076 Compare September 2, 2024 07:41
@ChanYiLin
Copy link
Contributor Author

This pull request is now in conflict. Could you fix it @ChanYiLin? 🙏

fixed.

@ChanYiLin ChanYiLin marked this pull request as ready for review September 2, 2024 07:41
@ChanYiLin
Copy link
Contributor Author

Hi @derekbit
This is ready for review. Thanks

Copy link

mergify bot commented Sep 7, 2024

This pull request is now in conflict. Could you fix it @ChanYiLin? 🙏

@ChanYiLin ChanYiLin force-pushed the LH8757_record_backing_image_real_size branch from 57b0076 to c3f4341 Compare September 19, 2024 07:41
@ChanYiLin
Copy link
Contributor Author

This pull request is now in conflict. Could you fix it @ChanYiLin? 🙏

fixed.

shuo-wu
shuo-wu previously approved these changes Sep 19, 2024
Copy link
Contributor

@shuo-wu shuo-wu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general LGTM.

pkg/util/util.go Outdated Show resolved Hide resolved
@ChanYiLin ChanYiLin force-pushed the LH8757_record_backing_image_real_size branch from c3f4341 to a01e9f2 Compare September 20, 2024 11:01
@ChanYiLin ChanYiLin requested a review from shuo-wu September 20, 2024 11:02
@ChanYiLin
Copy link
Contributor Author

Hi @derekbit
This has been reviewed, you can take a quick look and merge it.
Thanks

pkg/util/util.go Outdated Show resolved Hide resolved
pkg/sync/sync_file.go Outdated Show resolved Hide resolved
pkg/sync/sync_file.go Show resolved Hide resolved
@ChanYiLin ChanYiLin force-pushed the LH8757_record_backing_image_real_size branch from a01e9f2 to 94319ef Compare September 23, 2024 06:33
Copy link
Member

@derekbit derekbit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

ref: longhorn/longhorn 8757

Signed-off-by: Jack Lin <[email protected]>
@derekbit derekbit force-pushed the LH8757_record_backing_image_real_size branch from 94319ef to 20bda41 Compare September 23, 2024 07:22
@derekbit derekbit merged commit 9aff327 into longhorn:master Sep 23, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants