-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add real size to backing image #313
feat: add real size to backing image #313
Conversation
This pull request is now in conflict. Could you fix it @ChanYiLin? 🙏 |
2a1e68d
to
6379c44
Compare
fixed. |
PendingWait for longhorn/type PR: longhorn/types#26 |
6379c44
to
ff144ac
Compare
ff144ac
to
fabe6d3
Compare
This pull request is now in conflict. Could you fix it @ChanYiLin? 🙏 |
75011e6
to
57b0076
Compare
fixed. |
Hi @derekbit |
This pull request is now in conflict. Could you fix it @ChanYiLin? 🙏 |
57b0076
to
c3f4341
Compare
fixed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In general LGTM.
c3f4341
to
a01e9f2
Compare
Hi @derekbit |
a01e9f2
to
94319ef
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
ref: longhorn/longhorn 8757 Signed-off-by: Jack Lin <[email protected]>
94319ef
to
20bda41
Compare
ref: longhorn/longhorn#8757
realsize
of the backing image by using syscallrealsize
of backingimage in status and return to the caller (longhorn-manager/backing-image-controller)