Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(backupbackingimage): add parameters to backup backing image create proto #276

Merged
merged 1 commit into from
Aug 28, 2024
Merged

feat(backupbackingimage): add parameters to backup backing image create proto #276

merged 1 commit into from
Aug 28, 2024

Conversation

ChanYiLin
Copy link
Contributor

ref: longhorn/longhorn#8884

update

  • get the parameters from the grpc
  • pass the parameters to the backupstore so it can get the secret, secretNamespace

@ChanYiLin ChanYiLin requested a review from derekbit July 17, 2024 07:56
@ChanYiLin ChanYiLin self-assigned this Jul 17, 2024
@ChanYiLin ChanYiLin mentioned this pull request Jul 17, 2024
Closed
@ChanYiLin ChanYiLin force-pushed the LH8884_store_secret_in_backupbackingimage branch from 82b41ee to 08094c6 Compare July 17, 2024 08:30
@mergify Mergify
Copy link

mergify bot commented Jul 20, 2024

This pull request is now in conflict. Could you fix it @ChanYiLin? 🙏

@ChanYiLin ChanYiLin force-pushed the LH8884_store_secret_in_backupbackingimage branch from 08094c6 to cfca594 Compare August 23, 2024 07:51
derekbit
derekbit previously approved these changes Aug 26, 2024
View reviewed changes
Copy link
Member

@derekbit derekbit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@derekbit
Copy link
Member

@ChanYiLin Need to resolve conflicts first.

@derekbit
Copy link
Member

@ChanYiLin Need to resolve the conflicts. Thanks.

@ChanYiLin ChanYiLin force-pushed the LH8884_store_secret_in_backupbackingimage branch from cfca594 to 4fdfebe Compare August 27, 2024 06:54
@ChanYiLin
feat(backupbackingimage): add parameters to backup backing image crea…
3eb303c 
…te proto

ref: longhorn/longhorn 8884

Signed-off-by: Jack Lin <[email protected]>
@ChanYiLin ChanYiLin force-pushed the LH8884_store_secret_in_backupbackingimage branch from 4fdfebe to 3eb303c Compare August 27, 2024 06:59
@ChanYiLin
Copy link
Contributor Author

ChanYiLin commented Aug 27, 2024 •
edited
Loading

@ChanYiLin Need to resolve the conflicts. Thanks.

Done

  • updated the longhorn/types vendor
  • resolved conflicts

@ChanYiLin ChanYiLin requested a review from derekbit August 27, 2024 07:38
derekbit
derekbit approved these changes Aug 28, 2024
View reviewed changes
Copy link
Member

@derekbit derekbit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@derekbit derekbit merged commit e0449cb into longhorn:master Aug 28, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@derekbit derekbit derekbit approved these changes

Assignees

@ChanYiLin ChanYiLin

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ChanYiLin @derekbit